fix(stackctl): replace Bash 4+ associative array with POSIX-safe function#508
Merged
Conversation
wax911
commented
Jun 26, 2026
wax911
left a comment
Member
Author
There was a problem hiding this comment.
The shell change itself is the right direction: replacing local -A with a linear lookup keeps the script compatible with older Bash implementations.
Blocking concern: this PR also commits .slim/deepwork/issues-500-505.md, which is unrelated to #501 and duplicates planning/handoff context that now belongs on issues, especially #505. The issue #505 comment already defines the override direction and explicitly defers that work to a dedicated session, so this implementation PR should not carry a broad deepwork planning artifact.
Please remove the .slim/deepwork file from this PR and keep the change focused on stackctl.sh. The stackctl fix itself looks acceptable after that cleanup.
cc4a957 to
b67ec08
Compare
…tion Replaces local -A dir_to_stack=() (Bash 4+ only) in _secrets_deploy() with a linear-scan _dir_to_stack() function. macOS ships Bash 3.2 which does not support associative arrays. Also removes 2>/dev/null from the generator call so errors are visible. Ref: #501
b67ec08 to
f7c2368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #501.
Replaces
local -A dir_to_stack=()(Bash 4+ only) in_secrets_deploy()with a linear-scan_dir_to_stack()function. macOS ships Bash 3.2 which does not support associative arrays. Also removes2>/dev/nullfrom the generator call so errors are visible.