Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Allow Post Test Parking To Prevent Ramming Due to Custom Homing
My CR-30 has
[homing_override]defined. I've added a few mods to make it so that if it homes X first (default), it will ram into one of the bed nobs for leveling. To prevent this, I have defined a custom homing that force-moves X by +10mm before homing Y, raising Y by 20mm, and then homing X. This allows the homing to clear the leveling nob without issue. I further enhance this by ensuring that my PRINT_END and similar macros parks the nozzle close to X=0.The issue I ran into is that
TEST_SPEEDhomes the printer, even if already homed (which I think is required). If I run multiple iterations of TEST_SPEED, the previous iteration leaves the printer at X=[max - 1]. When the home runs for the current iteration, my hotend ends up ramming. With my memory, I keep forgetting to move the gantry back a bit to account for this prior to each test.I finally got tired of startaling myself every time I ran TEST_SPEED from the ramming, that I implemented this change. This makes it so that after the TEST_SPEED finishes, it'll park the nozzle based on the saved variables. If no saved variables exist, it stays at X=[max-1], but you can use
SAVE_VARIABLE VARIABLE=test_speed_park_x VALUE=150and it will then move X to 150.In this way, when the next homing is done, the gantry doesn't jam.
Note: I haven't tested this on a printer that doesn't have variables enabled, but I presume the default will handle that.