Skip to content

Bug: Fix nerve list per path to handle aliasing correctly #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbrnz merged 1 commit into from
Mar 5, 2026
Merged

Bug: Fix nerve list per path to handle aliasing correctly #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mapmaker/properties/pathways.py
View file
Open in desktop
Copy link
Collaborator

@dbrnz dbrnz Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment (and for the future) is to have another level of indentation on the for of a list comprehension, and another again if there's any if part -- then it's easier to see what the code is doing.

Copy link
Contributor Author

@napakalas napakalas Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll do.

Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,8 @@ def list_to_tuple(obj):
if conn_id in rendered_route_graphs
],
'node_nerves': [
list_to_tuple(n) for n in connectivity_graph.graph.get('nerves', [])
list_to_tuple(connectivity_graph.nodes[list_to_tuple(n)]['node'])
for n in connectivity_graph.graph.get('nerves', [])
if list_to_tuple(n) in available_nodes
],
'node_mappings': [
Expand Down