AM-879 AM-881 boat charging: add kw and status to location based on connector information#131
Merged
Merged
Conversation
fhaver-amsterdam
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the bridge boat-charging location endpoints to expose an overall status and a computed max_kw per location by aggregating connector information from charging station data.
Changes:
- Compute per-location
statusandmax_kwfrom charging-station connector data and include these fields in both location list and location detail responses. - Extend location serializers to include the new
max_kwfield. - Update/add tests for the new aggregation behavior and detail response enrichment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
bridge/boat_charging/views/location_view.py |
Adds connector-based aggregation to derive per-location status and max kW; enriches list and detail responses. |
bridge/boat_charging/views/base_view.py |
Updates location feature construction to include status and new max_kw property. |
bridge/boat_charging/tests/views/test_location_view.py |
Replaces/extends tests to cover the new aggregation logic and detail response fields. |
bridge/boat_charging/serializers/location_serializers.py |
Adds max_kw to the location properties serializer output. |
…ocations' into boat-charging/am-879-add-kw-to-locations # Conflicts: # bridge/boat_charging/views/location_view.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
bridgeboat-charging location endpoints to expose an overallstatusand a computedmax_kwper location by aggregating connector information from charging station data.Changes:
statusandmax_kwfrom charging-station connector data and include these fields in both location list and location detail responses.max_kwfield.Affected services
Definition of done
make openapi-diff)make dev)- [ ] Dependencies updated (make requirements)- [ ] Infrastructure config updated (aapp_azure_infra)- [ ] Loadtests for relevant endpoints (aapp_testing_loadtests)After PR created (and deployed on dev):
Guest login endpoint doesnt work anymore.