-
Notifications
You must be signed in to change notification settings - Fork 12
feat/chores: Serialization Behaviour, CI Improvements #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Eli Pinkerton (wallstop)
wants to merge
31
commits into
main
Choose a base branch
from
dev/wallstop/serialization-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
2703f29
chore(mcp): verify Unity MCP setup, gitignore client configs, add val…
wallstop 38074e8
ci(unity): add DxMessaging-style self-hosted Unity test + benchmark m…
wallstop 87f9f44
test(perf): faster suite via statistical sampling + Performance/Stres…
wallstop efe6f6b
fix(serialization): typed-exception contract + lint-clean the in-prog…
wallstop e66695a
chore: in-flight RuntimeSingleton/registry, Physics, and extension tw…
wallstop 464f5dc
chore: switch docs SVG assets to the Unity vector-graphics ScriptedIm…
wallstop a058f6a
ci(unity): Unity-6 single-threaded leg + third-party DI integration m…
wallstop 3704120
ci(perf): perf-delta reporting in the Unity benchmark job
wallstop 897628b
Fix Git Hooks
wallstop 21a6c97
Fix Licenses
wallstop b8f2036
CI fixes
wallstop 944a8c0
CI fixes
wallstop 63a01bf
Relocate skills index to skills/index.md with deterministic generator
wallstop fb91c10
Add slow-test report + wall-clock budget gate and UNH010 real-time-wa…
wallstop c939a38
Split SpriteCropper crop math into pure ComputeCrop for fast unit tests
wallstop 17e85b8
perf(tests): split fit-size math from asset I/O into a pure fixture
wallstop b106aad
perf(tests): split texture-settings diff from asset I/O into a pure f…
wallstop 1eb856a
test(anim): extract pure clip content-equality + add fast unit coverage
wallstop d5707a4
fix(anim): drop dead dependency-hashing + use WallMath.Approximately …
wallstop 89a95c2
Update gitignore
wallstop 78e3577
Test stall fixes
wallstop 0115eb6
Potential CI fixes
wallstop cb36e6d
CI fixes
wallstop c903da9
Potential CI fixes
wallstop b332709
Reflex fixes
wallstop 9ca9cf1
More Reflex fixes
wallstop 0b60d7d
Potential CI fixes
wallstop 6be7c84
Git Hook fixes
wallstop eafb0d5
EntityId Upgrades
wallstop e8d78cf
More CI fixes
wallstop fe4b841
Potential CI fixes
wallstop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,20 @@ | ||
| #!/usr/bin/env sh | ||
| # ============================================================================ | ||
| # POST-REWRITE HOOK: Invalidate caches after history rewrite | ||
| # ============================================================================ | ||
| # Triggered by: git rebase, git commit --amend, git filter-branch | ||
| # Purpose: Clear the license year cache since git log dates may have changed. | ||
| # ============================================================================ | ||
| set -eu | ||
|
|
||
| REPO_ROOT=$(git rev-parse --show-toplevel 2>/dev/null) | ||
| if [ -z "$REPO_ROOT" ]; then | ||
| exit 0 | ||
| hook_name="post-rewrite" | ||
| hook_impl="$hook_name.ps1" | ||
| hook_dir="$(CDPATH= cd "$(dirname "$0")" && pwd -P)" | ||
| hook_script="$hook_dir/$hook_impl" | ||
|
|
||
| if [ ! -f "$hook_script" ]; then | ||
| repo_root="$(git rev-parse --show-toplevel 2>/dev/null || true)" | ||
| if [ -n "$repo_root" ] && [ -f "$repo_root/.githooks/$hook_impl" ]; then | ||
| hook_script="$repo_root/.githooks/$hook_impl" | ||
| fi | ||
| fi | ||
|
|
||
| CACHE_FILE="$REPO_ROOT/.git/license-year-cache" | ||
| if [ -f "$CACHE_FILE" ]; then | ||
| rm -f "$CACHE_FILE" | ||
| echo "License year cache invalidated (history rewritten)." | ||
| if [ ! -f "$hook_script" ] || ! command -v pwsh >/dev/null 2>&1; then | ||
| exit 0 | ||
| fi | ||
|
|
||
| exec pwsh -NoProfile -File "$hook_script" "$@" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| #!/usr/bin/env pwsh | ||
| Set-StrictMode -Version Latest | ||
| $ErrorActionPreference = 'Stop' | ||
|
|
||
| $repoRoot = (& git rev-parse --show-toplevel 2>$null) | ||
| if ($LASTEXITCODE -ne 0 -or [string]::IsNullOrWhiteSpace($repoRoot)) { | ||
| exit 0 | ||
| } | ||
|
|
||
| $repoRoot = ([string]$repoRoot).Trim() | ||
| $cachePath = (& git -C $repoRoot rev-parse --git-path license-year-cache 2>$null) | ||
| if ($LASTEXITCODE -ne 0 -or [string]::IsNullOrWhiteSpace($cachePath)) { | ||
| exit 0 | ||
| } | ||
|
|
||
| $cachePath = ([string]$cachePath).Trim() | ||
| if (-not [System.IO.Path]::IsPathRooted($cachePath)) { | ||
| $cachePath = Join-Path $repoRoot $cachePath | ||
| } | ||
|
|
||
| if (Test-Path -LiteralPath $cachePath -PathType Leaf) { | ||
| Remove-Item -LiteralPath $cachePath -Force | ||
| Write-Host 'License year cache invalidated (history rewritten).' | ||
| } | ||
|
|
||
| exit 0 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post-rewrite skips cache clear
Medium Severity
The
post-rewriteshell wrapper exits successfully whenpost-rewrite.ps1is missing orpwshis not onPATH, so the license year cache is never removed after a history rewrite. The previous hook cleared that cache directly in shell on every successful run.Reviewed by Cursor Bugbot for commit fe4b841. Configure here.