fix: fix text overflow in repeating group table summary#4224
Open
walldenfilippa wants to merge 2 commits into
Open
fix: fix text overflow in repeating group table summary#4224walldenfilippa wants to merge 2 commits into
walldenfilippa wants to merge 2 commits into
Conversation
walldenfilippa
added
kind/bug
Contributor
📝 WalkthroughWalkthroughThis PR adjusts CSS styling in the repeating group table summary component to improve text wrapping on mobile. The change removes forced no-wrap behavior from validation messages and enables word-breaking for cell values, allowing longer text to display across multiple lines instead of overflowing. ChangesMobile table text wrapping in repeating group summary
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/layout/RepeatingGroup/Summary2/RepeatingGroupTableSummary/RepeatingGroupTableSummary.module.css`:
- Line 76: The CSS rule uses the deprecated declaration "word-break: break-word"
in RepeatingGroupTableSummary.module.css; replace that declaration with the
standard "overflow-wrap: break-word" (removing the deprecated word-break line)
so the RepeatingGroupTableSummary styles use overflow-wrap to achieve the
intended wrapping behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4a7ba2aa-21b4-4885-9581-07eddfd6d52b
📒 Files selected for processing (1)
src/layout/RepeatingGroup/Summary2/RepeatingGroupTableSummary/RepeatingGroupTableSummary.module.css
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
• Removes
white-space: nowrapfrom.cellValueand.cellValidationMessageinRepeatingGroupTableSummary.module.css, introduced in #4155• Replaces with
overflow-wrap: break-wordon.cellValueso long text wraps within the cell instead of overflowing the screenPR #4155 added
white-space: nowrapto keep validation messages horisontaly aligned across columns — withnowrap, all cell values stay on one line so validations start at the same horisontal position. However, this caused long text to overflow the table rather than wrapping.With this fix, validation messages in different columns may not be perfectly horisontaly aligned when eg. a cell contains long wrapping text and others do'nt. A proper alignment solution would require grid on the table rows, which is a larger refactor and should be treated as a separate issue if prioritized.
Before:
After:
Related Issue(s)
#4197
#4194
Verification/QA
kind/*andbackport*label to this PR for proper release notes groupingSummary by CodeRabbit