Add swarms regression test for bucket-split task rescheduling (Altinity/ClickHouse#1486)#118
Open
CarlosFelipeOR wants to merge 1 commit into
Open
Add swarms regression test for bucket-split task rescheduling (Altinity/ClickHouse#1486)#118CarlosFelipeOR wants to merge 1 commit into
CarlosFelipeOR wants to merge 1 commit into
Conversation
27 tasks
|
|
||
|
|
||
| @TestStep(Given) | ||
| def create_parquet_with_many_row_groups( |
Member
There was a problem hiding this comment.
This step needs a clean up afterwards.
| "swarms work only with antalya", | ||
| check_if_not_antalya_build, | ||
| ), | ||
| "/swarms/feature/task rescheduling/*": ( |
Member
There was a problem hiding this comment.
this fix is added to 25.8 Altinity/ClickHouse#1237, so xfail should be updated for it as well
| max_threads=1, | ||
| lock_object_storage_task_distribution_ms=2, | ||
| cluster_table_function_split_granularity="bucket", | ||
| cluster_table_function_buckets_batch_size=1, |
Member
There was a problem hiding this comment.
Why this setting is set to 1?
| assert sent_to_matched + sent_to_non_matched > 1, error( | ||
| "Bucket split was not active: expected more than one distributed task." | ||
| ) | ||
| assert processed_tasks_total > 1, error( |
Member
There was a problem hiding this comment.
Shouldn't we assert for 200 as total tasks: 200000 rows / 1000 rows in row group?
Member
There was a problem hiding this comment.
I always get 198, maybe it logging bad if node is killed.
| def feature(self, minio_root_user, minio_root_password, node=None): | ||
| """Check that task rescheduling works correctly when swarm replicas fail, | ||
| verifying data completeness after recovery.""" | ||
| if node is None: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Expected 200000 total rows, but got 165762)RESULT: 200000Made with Cursor