Wire security.kubernetes.tls.minVersion into the Kubernetes API client transport#2020
Open
Elmo33 wants to merge 1 commit into
Open
Wire security.kubernetes.tls.minVersion into the Kubernetes API client transport#2020Elmo33 wants to merge 1 commit into
Elmo33 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
security.kubernetes.tls.minVersionto1.3in chopconf but never applied it when building the client-go transport, so the K8s client could still negotiate TLS 1.2.GetClientsettime (same timing as the insecure-kubeconfig startup gate) viaOperatorConfig.ResolveK8sTLSMinVersion, and stamp it ontorest.ConfigwithWrap.chopConfigFileintoGetClientsetfrom the operator, keeper, and metrics-exporter entrypoints so all three binaries share the same behavior.Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info