Update default port names to Istio friendly names#1984
Open
brosenfi wants to merge 1 commit into
Open
Conversation
… app protocol. Signed-off-by: Brian Rosenfield <brosenfi@yahoo.com>
Collaborator
|
what is the motivation for these changes? |
Author
|
Hi @sunsingerus - adding the ability to run this operator within istio enabled clusters. We have noticed without these name changes that istio / envoy is not auto-detecting the protocols successfully in our environment ( see this description concerning istio's app protocol selection and app protocol selection as part of the name). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update default port names to more Istio friendly names indicating the app protocol.
Note I did not update the "interserver" port name as there appears to be indirectly linked references (within the operator) using that name - I had a local deployment fail when updating this name to "http-interserver". Also, istio's app protocol auto-detection seems to work fine for this interserver connection.