Skip to content

fix(resume): validate part completeness before skipping#1387

Draft
leno23 wants to merge 1 commit into
Altinity:masterfrom
leno23:hermes-auto/clickhouse-backup-1382-resume-validate-parts
Draft

fix(resume): validate part completeness before skipping#1387
leno23 wants to merge 1 commit into
Altinity:masterfrom
leno23:hermes-auto/clickhouse-backup-1382-resume-validate-parts

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 17, 2026

Summary

  • validate resume-marked download parts against the remote file list before skipping them locally
  • validate resume-marked uncompressed upload parts against the expected local file list before skipping them remotely
  • re-check compressed upload resume entries with StatFile before skipping an archive upload
  • add regression coverage for missing .cmrk3/part files during resume validation

Fixes #1382

Tests

  • go test ./pkg/backup -run 'TestIs(Local|Remote)PartCompleteRequires' -count=1
  • go test ./pkg/backup -count=1
  • go test ./pkg/... -count=1

Prevent --resume from trusting stale processed-part state when local download parts or remote upload parts are incomplete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conservative resume validation: verify part file completeness before skipping

1 participant