Skip to content

fix: skip missing remote table metadata#1386

Draft
leno23 wants to merge 1 commit into
Altinity:masterfrom
leno23:hermes-auto/clickhouse-backup-1379-skip-missing-metadata
Draft

fix: skip missing remote table metadata#1386
leno23 wants to merge 1 commit into
Altinity:masterfrom
leno23:hermes-auto/clickhouse-backup-1379-skip-missing-metadata

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 17, 2026

Summary

  • detect permanent remote metadata-missing errors before the download metadata retry loop keeps backing off
  • warn and skip the affected table when its JSON metadata file is absent on remote storage
  • preserve the existing optional .sql handling for incremental/embedded metadata and return non-not-found errors directly
  • add a focused regression test for the not-found classifier patterns seen from common object stores

Tests

  • go test ./pkg/backup -run TestIsRemoteMetadataNotFound -count=1
  • go test ./pkg/backup -count=1

Closes #1379

Treat object-store metadata 404s as permanent so download skips the
affected table immediately instead of exhausting the retry backoff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip missing metadata files gracefully instead of retrying forever

1 participant