Skip to content

fix: allow resume without download state file#1385

Draft
leno23 wants to merge 1 commit into
Altinity:masterfrom
leno23:hermes-auto/clickhouse-backup-1383-resume-missing-state
Draft

fix: allow resume without download state file#1385
leno23 wants to merge 1 commit into
Altinity:masterfrom
leno23:hermes-auto/clickhouse-backup-1383-resume-missing-state

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 17, 2026

Summary

  • allow download --resume to continue when the local backup directory exists but download.state2 is missing
  • keep the existing resume warning when the state file is present and log a clearer warning for resume-from-scratch
  • add a regression test covering the missing-state-file resume path

Tests

  • go test ./pkg/backup -run TestResumeExistingBackupAllowsMissingStateFile -count=1
  • go test ./pkg/backup -count=1

Closes #1383

Treat download.state2 as optional for --resume so an existing backup
directory without state can be validated and resumed from scratch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix --resume crash when download.state2 file is missing

1 participant