feat: show table/column COMMENTs across schema views + compression size %#119
Merged
Conversation
…n size % Table COMMENTs now surface as a native hover tooltip on both the compact inline schema-lineage graph and the fullscreen rich-card graph, and in the table-info panel's header. Column comments get their own (2x wider) column in that panel's table, replacing the "uncompressed" byte count with "size %" — the percentage of the original size still on disk after compression. Also fixes issues surfaced by code review: truncate()'s off-by-one for max<=0, deduped 4 pre-existing copies of the same slice+ellipsis logic onto the shared truncate() helper, and normalized comment handling across schema-graph.js's node()/external() factories. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xwt1KZ3rmKfM26jvyZQD2t
…t cap Matches the compact inline graph's behavior for consistency: the table comment never occupies a line on the fullscreen card, only a <title> tooltip on the whole card — so it can't affect card height/width. The table-info panel's header comment cap grows 80 -> 120 (the header row has ~1.5x the room the columns table's comment cells do). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xwt1KZ3rmKfM26jvyZQD2t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMENTs now show as a native hover tooltip on the node in both the compact inline schema-lineage graph and the fullscreen rich-card graph, and in the table-info panel's header next to the kind badge.MAX_COL_COMMENT40 → 80 chars).1%, not "99% saved" — deliberately "how much is left," not "how much was saved").Also fixes (from code review of the initial cut)
truncate()'s off-by-one:truncate('abc', 0)returned'ab…'(longer thanmax) instead of clamping.clampType,inferQueryName,firstRowPreview, results-grid cell tooltip) onto the sharedtruncate()helper.schema-graph.js'snode()/external()factories (trimming, consistent''default).Test plan
npm test— 1317/1317 passing, 100% stmt/line coverage maintained on every touched fileantalyademo ClickHouse cluster (ontime.dim_airports_bts_full,ontime.fact_ontime— 231M rows / 6.88GB): table/column comments render with correct capping + full-text tooltips in all three surfaces,size %computes correctly (e.g.Reporting_Airline→1%; alias columns with no physical storage →—)🤖 Generated with Claude Code
https://claude.ai/code/session_01Xwt1KZ3rmKfM26jvyZQD2t