Skip to content

Backport of #93814 to 25.8: Fix logical error in Map column types when used with empty tuple #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianton-ru wants to merge 1 commit into
base: stable-25.8
Choose a base branch
from
+49 −1
Open

Backport of #93814 to 25.8: Fix logical error in Map column types when used with empty tuple #1994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Functions/array/array.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ class FunctionArray : public IFunction
const size_t tuple_size = concrete_out_data->tupleSize();
if (tuple_size == 0)
{
out_data.insertManyDefaults(columns.size());
/// Tuple() has no subcolumns to fill. Create `columns.size()` elements per row to match array offsets
out_data.insertManyDefaults(columns.size() * input_rows_count);
}
else
{
Expand Down
4 changes: 4 additions & 0 deletions tests/queries/0_stateless/03786_empty_tuple_map_array.reference
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{((),1):1,((),1):1}
{((),1):1,((),1):1}
{}
{((),1):1,((),1):1}
43 changes: 43 additions & 0 deletions tests/queries/0_stateless/03786_empty_tuple_map_array.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
DROP TABLE IF EXISTS t0;

CREATE TABLE t0 (c0 Map(Tuple(Tuple(), Int), Int))
ENGINE = MergeTree()
ORDER BY tuple();

INSERT INTO TABLE t0 (c0)
VALUES
(
map(
((), 1), 1,
((), 1), 1
)
),
(
map(
((), 1), 1,
((), 1), 1
)
);

SELECT * FROM t0;


DROP TABLE IF EXISTS t1;

CREATE TABLE t1 (c0 Map(Tuple(Tuple(), Int), Int))
ENGINE = MergeTree()
ORDER BY tuple();

INSERT INTO TABLE t1 (c0)
VALUES
(
map()
),
(
map(
((), 1), 1,
((), 1), 1
)
);

SELECT * FROM t1;
Loading