Fix Iceberg read optimization returning NULLs for stats-less manifests#1895
Fix Iceberg read optimization returning NULLs for stats-less manifests#1895il9ue wants to merge 35 commits into
Check failed
There are 28 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | 5ec03a9 | Fix Iceberg read optimization returning NULLs for ... | Valid sign-off found |
| 🟢 | d3c0eb5 | Merge branch 'antalya-26.3' into fix/iceberg-empty... | Skipped: sign-off not required in merge commit |
| 🟢 | 056eb1a | Rework Iceberg empty-stats tests per review feedba... | Valid sign-off found |
| 🔴 | 17ef6e7 | cast like insert select | Sign-off not found |
| 🔴 | c88f69e | tmp | Sign-off not found |
| 🔴 | 67489f2 | fix build and tests | Sign-off not found |
| 🔴 | 245c0bb | yet another impl | Sign-off not found |
| 🔴 | 8d2b086 | fix tests and background setting | Sign-off not found |
| 🔴 | 4100ecd | fix tests | Sign-off not found |
| 🔴 | 914de72 | some more test fixes | Sign-off not found |
| 🔴 | 6f822c8 | add docs | Sign-off not found |
| 🔴 | f521a95 | improve docs with a warning | Sign-off not found |
| 🔴 | 41c64ed | hmm... maybe incomplete, gotta continue it tomorro... | Sign-off not found |
| 🔴 | 3b177ed | add tests covering corner tricky case | Sign-off not found |
| 🔴 | 4a75d52 | rmv task ttl | Sign-off not found |
| 🔴 | a676814 | cleanup | Sign-off not found |
| 🔴 | 16dac3c | missing piece | Sign-off not found |
| 🟢 | 978f9e1 | Skip store_data.py pre-hook in MasterCI to avoid F... | Valid sign-off found |
| 🔴 | 0322774 | Add 'PRs in Release' table to report | Sign-off not found |
| 🔴 | c175440 | highlight labels for unverified PRs | Sign-off not found |
| 🔴 | a7113d0 | report: fix _find_rebase_baseline | Sign-off not found |
| 🔴 | 458420e | ensure extra git history is fetched in get_prs_in_... | Sign-off not found |
| 🔴 | 27215e6 | no longer consider labels no-verification-needed a... | Sign-off not found |
| 🔴 | 7618b0b | simplify verified check | Sign-off not found |
| 🔴 | 8d7c262 | swap columns | Sign-off not found |
| 🔴 | 6e748a7 | add tabbed navigation to report | Sign-off not found |
| 🔴 | a4f0276 | support # in url with tabs, improve tab button vis... | Sign-off not found |
| 🔴 | 46c7956 | switch styling from pill to tab | Sign-off not found |
| 🟢 | 83f75c4 | Escape PR title and labels in PRs in Release table... | Valid sign-off found |
| 🟢 | 3e92ac5 | Fix Grype Scan: pin boto3==1.43.33 to avoid botoco... | Valid sign-off found |
| 🔴 | 9b79223 | fix regression not respecting arm skip flag | Sign-off not found |
| 🔴 | 46c8d32 | cache vended catalog credentials | Sign-off not found |
| 🔴 | c10599b | add test | Sign-off not found |
| 🔴 | 6b15b03 | Address review (#1895) | Sign-off not found |
| 🟢 | 2bc7944 | Merge branch 'antalya-26.3' into fix/iceberg-empty... | Skipped: sign-off not required in merge commit |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~35 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin fix/iceberg-empty-stats-26.3