Antalya 26.3: normalizing format check using lower case#1803
Open
zvonand wants to merge 2 commits into
Open
Conversation
…solution in next commit) --- Original cherry-pick message follows: Merge pull request ClickHouse#102825 from grantholly-clickhouse/fix_iceberg_parquet_lru_cache normalizing format check using lower case # Conflicts: # src/Storages/ObjectStorage/StorageObjectStorageSource.cpp
zvonand
added
releasy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Cherry-picked from ClickHouse#102825.
Documentation entry for user-facing changes
It looks like we were not able to use the parquet metadata cache because the parquet format string gets passed many different ways and we were only looking for "Parquet". For example "PARQUET" from tools like Spark, "Parquet" internally in our code base, and "parquet" if you are following the iceberg spec.
In the future, it would be good to normalize this format string in one place, because we are dealing with this same issue in a few different places in the code.