feature (iceberg): Implement TRUNCATE TABLE for Iceberg Engine (REST …#1655
feature (iceberg): Implement TRUNCATE TABLE for Iceberg Engine (REST …#1655il9ue wants to merge 3 commits into
Conversation
…catalog support) Forward-port of Iceberg TRUNCATE TABLE from antalya-26.1 to antalya-26.3. Adapted to antalya-26.3 API changes in RestCatalog constructor, DatabaseDataLakeSetting, and related interfaces. See original implementation details in antalya-26.1 PR #1529. Signed-off-by: Daniel Q. Kim <daniel.kim@altinity.com>
db43b6b to
e229240
Compare
On CI Failures & Asking a reviewFlagging the CI failures for review. All observed failures are pre-existing and unrelated to the Iceberg TRUNCATE changes in this PR.
Docker CVEs (CVE-2026-28388, CVE-2026-28389, CVE-2026-28390, CVE-2026-31790, CVE-2026-40200)
These require a base image update by the Docker/infra team and are unrelated to any C++ code changes in this PR. The same CVEs appear on the base This PR is a forward-port of the Iceberg TRUNCATE TABLE feature from |
arthurpassos
left a comment
There was a problem hiding this comment.
Have you submitted this to upstream?
| // (distinct from snapshot ID 0 which is a valid snapshot). | ||
| Int64 parent_snapshot_id = actual_table_state_snapshot.snapshot_id.value_or(-1); | ||
|
|
||
| auto config_path = persistent_components.table_path; |
There was a problem hiding this comment.
This will change once #1785 is merged. Not sure about the ordering. Looking at the "process correctness perspective", this frontport should be merged first. At the same time, that PR will certainly introduce conflicts that are best resolved by the author
QA Verification — ✅ ApprovedPR #1655 (Iceberg engine TRUNCATE TABLE — forward-port to antalya-26.3) is safe and did not introduce any regression. This is a forward-port of PR #1529 (merged into Feature tests ✅
Summary of remaining failures
Key evidenceForward-port precedent — The original PR #1529 introduced this feature into Cross-PR confirmation of infra failures — The mass-fails in |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Frontport for Antalya 26.3
Adaptation notes for antalya-26.3
The following API changes between antalya-26.1 and antalya-26.3 required adaptation:
RestCatalogconstructor signature updated to matchantalya-26.3calling convention inDataLakeConfiguration.hDatabaseDataLakeSettingmember names updatedCargo.lockrestored toantalya-26.3version (our changes do not touch any Rust code)All feature logic is identical to the merged antalya-26.1 implementation.
CI/CD Options
Exclude tests:
Regression jobs to run: