Skip to content

Features/25.3/fips ch binary extended testing - third attempt #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Enmk wants to merge 2 commits into
base: releases/25.3.8-fips
Choose a base branch
from
Open

Features/25.3/fips ch binary extended testing - third attempt #1567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe0baa4
Sanity check that there are no NULL symbols
Enmk Mar 23, 2026
64c74a5
Less broad symbol weakening
Enmk Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions contrib/openssl-cmake/build_test_harness.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,23 @@ build_target() {
awk -v p="$PREFIX" '{print p $0 " " $0}' "$obj_dir/undef.txt" > "$obj_dir/redefine.txt"
awk -v p="$PREFIX" '{print p $0 " " $0}' "$obj_dir/entry.txt" >> "$obj_dir/redefine.txt"

# Collect defined symbols — only these need weakening (to avoid
# duplicate-definition errors when multiple archives pull the same
# libstdc++ members). Undefined symbols must stay strong so the
# linker errors out if they cannot be resolved, instead of silently
# binding them to NULL.
# Names are prefixed to match post-pass-1 state.
nm --defined-only "$obj_dir/combined.o" | awk -v p="$PREFIX" \
'NF>=3{print p $NF}' | sort -u > "$obj_dir/weaken.txt"

# Two passes: objcopy applies --redefine-syms BEFORE --prefix-symbols
# in a single invocation, so we must split them.
# Pass 1: prefix every symbol.
objcopy --prefix-symbols="$PREFIX" "$obj_dir/combined.o"
# Pass 2: restore undefined refs + entry point to original names,
# and weaken all defined symbols so duplicates across archives
# (same libstdc++ members pulled into shim, handshaker, acvp) don't clash.
objcopy --redefine-syms="$obj_dir/redefine.txt" --weaken "$obj_dir/combined.o"
# and weaken only defined symbols.
objcopy --redefine-syms="$obj_dir/redefine.txt" \
--weaken-symbols="$obj_dir/weaken.txt" "$obj_dir/combined.o"

ar rcs "$OUTDIR/lib${name}.a" "$obj_dir/combined.o"
rm -rf "$obj_dir"
Expand Down