-
Notifications
You must be signed in to change notification settings - Fork 12
Allow merge tree materialized / alias columns to be exported through part export #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: antalya-25.8
Are you sure you want to change the base?
Conversation
|
I will add more details tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed2bb31baa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| auto defaults_dag = evaluateMissingDefaults( | ||
| *current_header, | ||
| all_columns, | ||
| metadata_snapshot->getColumns(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align export output columns with destination physical schema
This step builds defaults/reordering from all_columns, which includes ALIAS columns from the source. The export sink’s header comes from the destination’s getSampleBlock() (physical-only; see StorageInMemoryMetadata::getSampleBlock()), so if the destination table also defines an ALIAS column (same schema as source), the pipeline will output that alias column and StorageObjectStorageSink::consume() will throw because Block::cloneWithColumns requires the column count to match the physical header. This means EXPORT PART fails for tables that include aliases on the destination. Consider filtering to the destination’s physical columns (or using its sample block) when building the output DAG.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Informative, but not quite accurate. AS of now, object storage tables do not support "special" columns like alias or materialized. So these scenarios can't happen.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow merge tree materialized / alias columns to be exported through part export; This is done in two steps:
Example:
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: