-
Notifications
You must be signed in to change notification settings - Fork 12
Antalya 25.8 Backport of #93866 - Google cloud storage support for data lakes catalogs #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: antalya-25.8
Are you sure you want to change the base?
Conversation
Google cloud storage support for data lakes catalogs
| if (capitalize_first_letter(storage_type_str) == "S3a") | ||
| else if (capitalize_first_letter(storage_type_str) == "S3a" || storage_type_str == "oss" || storage_type_str == "gs") | ||
| { | ||
| fiu_do_on(DB::FailPoints::database_iceberg_gcs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular bit I don't really like. It's there only for the sake of the integration test. But I've left it intact to be more aligned with the upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better & easier to keep it consistent 👍
arthurpassos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
QA VerificationThis PR was verified manually using a real Iceberg setup backed by Google Cloud Storage (GCS) and a local Nessie REST catalog. The verification followed the reproduction steps documented in issue #1199. Test environment
Validation stepsBefore running the ClickHouse queries:
This ensures the
ClickHouse validationCREATE DATABASE demo_local
ENGINE = DataLakeCatalog('http://localhost:19120/iceberg')
SETTINGS
catalog_type = 'rest',
storage_endpoint = 'https://storage.googleapis.com',
warehouse = 'warehouse';USE demo_local;SHOW TABLES;Result: SELECT count() FROM `local_dataset.taxi_dataset`;Result: Result
✅ Confirmed working when using Iceberg tables stored on GCS and accessed via the Nessie REST catalog. |
Google cloud storage support for data lakes catalogs (fixes #1199)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Google cloud storage support for data lakes (ClickHouse#93866 by @scanhex12)
CI/CD Options
Exclude tests:
Regression jobs to run: