Skip to content

ci(release): cap dist-* build-artifact retention at 2 days #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dev-punia-altimate wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

ci(release): cap dist-* build-artifact retention at 2 days #953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b31f6
ci(release): cap dist-* build-artifact retention at 2 days
dev-punia-altimate Jun 18, 2026
e6372f2
ci(release): use 5-day dist-* retention for extra re-run margin
dev-punia-altimate Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ jobs:
name: dist-${{ matrix.name }}
path: packages/opencode/dist/
compression-level: 1
# These are intra-run couriers: the publish + gh-release jobs download
# them within the same run, then the binaries live permanently as npm
# packages + GitHub Release assets. Keep them only long enough to span
# the run (worst run ~62 min) plus margin for a next-day partial re-run,
# so they don't accumulate against the org artifact-storage quota.
retention-days: 5
Comment on lines +133 to +135

@coderabbitai coderabbitai Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Set retention to the intended 2 days (not 5).

Line 135 conflicts with the stated PR objective (retention-days: 2). Given prior org-wide quota exhaustion and CreateArtifact failures, this value mismatch should be corrected in this PR.

Suggested fix 
-          retention-days: 5
+          retention-days: 2
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# the run (worst run ~62 min) plus margin for a next-day partial re-run,
# so they don't accumulate against the org artifact-storage quota.
retention-days: 5
# the run (worst run ~62 min) plus margin for a next-day partial re-run,
# so they don't accumulate against the org artifact-storage quota.
retention-days: 2
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml around lines 133 - 135, In the
.github/workflows/release.yml file, locate the retention-days configuration
(currently set to 5) and change the value from 5 to 2 to align with the PR
objective and address the organization's artifact storage quota concerns
mentioned in the comment.

@cubic-dev-ai cubic-dev-ai Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The PR title says "cap dist-* build-artifact retention at 2 days" and the Risks/Rollout sections reference a "2-day window," but this line sets retention-days: 5. If 5 days is intentional (as the inline comment and description body suggest), the PR title and rollout notes should be updated to avoid confusion. If 2 days was the actual intent, the code is wrong.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/release.yml, line 135:

<comment>The PR title says "cap dist-* build-artifact retention at 2 days" and the Risks/Rollout sections reference a "2-day window," but this line sets `retention-days: 5`. If 5 days is intentional (as the inline comment and description body suggest), the PR title and rollout notes should be updated to avoid confusion. If 2 days was the actual intent, the code is wrong.</comment>

<file context>
@@ -130,8 +130,9 @@ jobs:
-          retention-days: 2
+          # the run (worst run ~62 min) plus margin for a next-day partial re-run,
+          # so they don't accumulate against the org artifact-storage quota.
+          retention-days: 5
 
   # ---------------------------------------------------------------------------
</file context>


# ---------------------------------------------------------------------------
# Verdaccio sanity suite — tests the real `npm install -g` flow BEFORE
Expand Down
Loading