Skip to content

Security: Hardcoded absolute path in drizzle.config.ts database URL #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 8 commits into
base: main
Choose a base branch
from
+4 −2
Open

Security: Hardcoded absolute path in drizzle.config.ts database URL #948

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b78b276
fix(opencode): hardcoded absolute path in drizzle.config.ts datab
tomaioo Jun 16, 2026
adfcd05
fix: address review feedback — <!-- code-review-finding -->
tomaioo Jun 17, 2026
dccf9dd
fix: address review feedback — <!-- code-review-finding -->
tomaioo Jun 19, 2026
53f25c2
fix: address review feedback — <!-- code-review-finding -->
tomaioo Jun 19, 2026
96f932a
fix: address review feedback — <!-- code-review-finding -->
tomaioo Jun 19, 2026
259217b
fix: address review feedback — <!-- code-review-finding -->
tomaioo Jun 19, 2026
4114b24
fix: address review feedback — <!-- code-review-finding -->
tomaioo Jun 20, 2026
a3d03e2
fix: address review feedback — <!-- code-review-finding -->
tomaioo Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/opencode/drizzle.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import os from "os"
import path from "path"

@dev-punia-altimate dev-punia-altimate Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[🔴 HIGH] The os module is missing an import. Please add import os from "os" since os.homedir() is used below.

Suggested change:

Suggested change
import path from "path"
import os from "os"
import path from "path"

import { defineConfig } from "drizzle-kit"

export default defineConfig({
dialect: "sqlite",
schema: "./src/**/*.sql.ts",
out: "./migration",
dbCredentials: {
url: "/home/thdxr/.local/share/opencode/opencode.db",
url: process.env.OPENCODE_DB_URL || path.join(os.homedir(), ".local", "share", "opencode", "opencode.db"),
Comment thread
coderabbitai[bot] marked this conversation as resolved.
},
})
})
Loading