Conversation
…nto feature/share-button
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
|
…nto feature/share-button
rugeli
commented
Feb 16, 2026
Comment on lines
+7
to
+8
| import DownloadIcon from "../../assets/download.svg?react"; | ||
| import ShareIcon from "../../assets/share.svg?react"; |
Contributor
Author
There was a problem hiding this comment.
with vite-plugin-svgr, we treat svgs as react components, so styles (e.g. stroke="currentColor") inherit correctly
rugeli
commented
Feb 16, 2026
Comment on lines
+10
to
+14
| const statusBarButtonProps = { | ||
| color: "primary" as const, | ||
| variant: "filled" as const, | ||
| className: "status-bar-button", | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
extracted shared props for the Download and Share buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
closes #173
Solution
What I/we did to solve this problem
added aSharelink to the navbarclicking
Shareopens an antd modal displaying the copiable URLupdates
following feedback from @thao-do:
Sharebutton to the bottom Status bar, matching the [design](move the Share button to the bottom Status bar, matching the design)Sharebutton follows the same behavior asDownload packing resultbuttonShare packing resultas suggestednote: the button color isn't quite matching the design yet, we're planning to do a broader color alignment in a follow-up ticket #183
next steps:
Download packing resultbutton for example recipes #182Type of change
Please delete options that are not relevant.