-
Notifications
You must be signed in to change notification settings - Fork 164
MCH: added plots per cru link #2592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
knopers8
merged 8 commits into
AliceO2Group:master
from
AliceMCH:mch-add-plots-per-cru-link
Aug 8, 2025
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ed707b7
[MCH] added averaging over SOLAR links
aferrero2707 098c544
[MCH] added helper functions for handling SOLAR indexes and histogram…
aferrero2707 2d09135
[MCH] updated Pedestals Task histogram decorations
aferrero2707 b900cf7
[MCH] added plots as function of SOLAR links
aferrero2707 6409144
[MCH] added checkers for SOLAR-based plots
aferrero2707 9ccfc80
[MCH] added aggregator task for DE and SOLAR qualities
aferrero2707 a90f036
[MCH] fixed clang errors
aferrero2707 0056180
[MCH] added review suggestions
aferrero2707 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -19,18 +19,17 @@ | |||||
| #ifndef QC_MODULE_MCH_PP_PRECLUSTERS_H | ||||||
| #define QC_MODULE_MCH_PP_PRECLUSTERS_H | ||||||
|
|
||||||
| #include "QualityControl/PostProcessingInterface.h" | ||||||
|
|
||||||
| #include "MCH/PostProcessingConfigMCH.h" | ||||||
| #include "MCH/Helpers.h" | ||||||
| #include "Common/TH2Ratio.h" | ||||||
| #include "MCH/HistoOnCycle.h" | ||||||
| #include "MCH/EfficiencyPlotter.h" | ||||||
| #include "MCH/EfficiencyTrendsPlotter.h" | ||||||
| #include "MCH/ClusterSizePlotter.h" | ||||||
| #include "MCH/ClusterSizeTrendsPlotter.h" | ||||||
| #include "MCH/ClusterChargePlotter.h" | ||||||
| #include "MCH/ClusterChargeTrendsPlotter.h" | ||||||
| #include "Common/ReferenceComparatorTask.h" | ||||||
| #include "Common/TH2Ratio.h" | ||||||
|
|
||||||
| namespace o2::quality_control::repository | ||||||
| { | ||||||
|
|
@@ -45,7 +44,7 @@ namespace o2::quality_control_modules::muonchambers | |||||
| { | ||||||
|
|
||||||
| /// \brief A post-processing task which processes and trends MCH pre-clusters and produces plots. | ||||||
| class PreclustersPostProcessing : public PostProcessingInterface | ||||||
| class PreclustersPostProcessing : public ReferenceComparatorTask | ||||||
| { | ||||||
| public: | ||||||
| PreclustersPostProcessing() = default; | ||||||
|
|
@@ -73,6 +72,8 @@ class PreclustersPostProcessing : public PostProcessingInterface | |||||
| static std::string clusterChargeSourceName() { return "clcharge"; } | ||||||
| static std::string clusterSizeSourceName() { return "clsize"; } | ||||||
|
|
||||||
| TH1* getHistogram(std::string plotName); | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this might become a bottleneck here, but in principle it's better to avoid copies.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, I will use the string_view |
||||||
|
|
||||||
| bool mFullHistos{ false }; | ||||||
| bool mEnableLastCycleHistos{ false }; | ||||||
| bool mEnableTrending{ false }; | ||||||
|
|
@@ -102,7 +103,10 @@ class PreclustersPostProcessing : public PostProcessingInterface | |||||
| std::unique_ptr<ClusterChargeTrendsPlotter> mClusterChargeTrendsPlotter; | ||||||
| std::unique_ptr<ClusterSizeTrendsPlotter> mClusterSizeTrendsPlotter; | ||||||
|
|
||||||
| std::unique_ptr<TH2F> mHistogramQualityPerDE; ///< quality flags for each DE, to be filled by checker task | ||||||
| std::unique_ptr<TH2F> mHistogramQualityPerDE; ///< quality flags for each DE, to be filled by checker task | ||||||
| std::unique_ptr<TH2F> mHistogramQualityPerSolar; ///< quality flags for each SOLAR, to be filled by checker task | ||||||
|
|
||||||
| std::vector<TH1*> mHistogramsAll; | ||||||
| }; | ||||||
|
|
||||||
| template <typename T> | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.