Skip to content

ITS/Clusters: increased ranges of some plots #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 3 commits into from
Feb 11, 2025
Merged

ITS/Clusters: increased ranges of some plots #2494

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
956e936
Increased ranges and type of the cluster size histograms for Layer
IsakovAD Jan 13, 2025
7ac4585
Further increase of ranges
IsakovAD Jan 20, 2025
30c69e1
clang
IsakovAD Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Modules/ITS/include/ITS/ITSClusterTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ class ITSClusterTask : public TaskInterface
std::shared_ptr<TH2DRatio> hAverageClusterSizeSummaryOB[NLayer];

// Layer summary
TH1D* hClusterSizeLayerSummary[NLayer] = { nullptr };
TH1D* hClusterTopologyLayerSummary[NLayer] = { nullptr };
TH1D* hGroupedClusterSizeLayerSummary[NLayer] = { nullptr };
TH1L* hClusterSizeLayerSummary[NLayer] = { nullptr };
TH1L* hClusterTopologyLayerSummary[NLayer] = { nullptr };
TH1L* hGroupedClusterSizeLayerSummary[NLayer] = { nullptr };

// Anomalies plots
TH2D* hLongClustersPerChip[3] = { nullptr };
Expand Down
6 changes: 3 additions & 3 deletions Modules/ITS/src/ITSClusterTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,19 +472,19 @@ void ITSClusterTask::createAllHistos()
hMultPerChipWhenLongClusters[iLayer]->SetStats(0);
}

hClusterSizeLayerSummary[iLayer] = new TH1D(Form("Layer%d/AverageClusterSizeSummary", iLayer), Form("Layer%dAverageClusterSizeSummary", iLayer), 100, 0, 100);
hClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageClusterSizeSummary", iLayer), Form("Layer%dAverageClusterSizeSummary", iLayer), 1000, 0, 1000);
Copy link
Copy Markdown
Collaborator

@iravasen iravasen Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to set the maximum to 128*128?

hClusterSizeLayerSummary[iLayer]->SetTitle(Form("Cluster size summary for Layer %d", iLayer));
addObject(hClusterSizeLayerSummary[iLayer]);
formatAxes(hClusterSizeLayerSummary[iLayer], "Cluster Size (pixels)", "counts", 1, 1.10);
hClusterSizeLayerSummary[iLayer]->SetStats(0);

hGroupedClusterSizeLayerSummary[iLayer] = new TH1D(Form("Layer%d/AverageGroupedClusterSizeSummary", iLayer), Form("Layer%dAverageGroupedClusterSizeSummary", iLayer), 100, 0, 100);
hGroupedClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageGroupedClusterSizeSummary", iLayer), Form("Layer%dAverageGroupedClusterSizeSummary", iLayer), 1000, 0, 1000);
Copy link
Copy Markdown
Collaborator

@iravasen iravasen Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Copy Markdown
Collaborator Author

@IsakovAD IsakovAD Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ivan,

Sure. Fixed in the next commit

hGroupedClusterSizeLayerSummary[iLayer]->SetTitle(Form("Cluster size summary for Layer %d", iLayer));
addObject(hGroupedClusterSizeLayerSummary[iLayer]);
formatAxes(hGroupedClusterSizeLayerSummary[iLayer], "Grouped Cluster Size (pixels)", "counts", 1, 1.10);
hGroupedClusterSizeLayerSummary[iLayer]->SetStats(0);

hClusterTopologyLayerSummary[iLayer] = new TH1D(Form("Layer%d/ClusterTopologySummary", iLayer), Form("Layer%dClusterTopologySummary", iLayer), 300, 0, 300);
hClusterTopologyLayerSummary[iLayer] = new TH1L(Form("Layer%d/ClusterTopologySummary", iLayer), Form("Layer%dClusterTopologySummary", iLayer), 300, 0, 300);
hClusterTopologyLayerSummary[iLayer]->SetTitle(Form("Cluster topology summary for Layer %d", iLayer));
addObject(hClusterTopologyLayerSummary[iLayer]);
formatAxes(hClusterTopologyLayerSummary[iLayer], "Cluster Topology (ID)", "counts", 1, 1.10);
Expand Down