Skip to content

[Trigger,PWGEM] update globalDimuonFilter.cxx for Run4 - #17621

Open
dsekihat wants to merge 2 commits into
AliceO2Group:masterfrom
dsekihat:swt
Open

[Trigger,PWGEM] update globalDimuonFilter.cxx for Run4#17621
dsekihat wants to merge 2 commits into
AliceO2Group:masterfrom
dsekihat:swt

Conversation

@dsekihat

Copy link
Copy Markdown
Collaborator

[Trigger,PWGEM] update globalDimuonFilter.cxx for Run4

alibuild
alibuild previously approved these changes Aug 26, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 7 errors, ⚠️ 45 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 69a97c1 at 2026-08-27 00:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 4 warnings.'
Found 10 errors and 4 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/d0f4a24df6187f6a963e2c4542ba44a2e71f5df3/O2Physics-code-check/errors.txt
EventFiltering/PWGEM/globalDimuonFilter.cxx:41:1: error: included header Utils.h is not used directly [misc-include-cleaner,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:61:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:72:33: error: no header providing "uint16_t" is directly included [misc-include-cleaner,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:189:39: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:190:24: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:298:33: error: no header providing "FLT_MAX" is directly included [misc-include-cleaner,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:408:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:555:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:637:22: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:643:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/d0f4a24df6187f6a963e2c4542ba44a2e71f5df3/O2Physics-code-check/warnings.txt
EventFiltering/PWGEM/globalDimuonFilter.cxx:59:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
EventFiltering/PWGEM/globalDimuonFilter.cxx:188:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
EventFiltering/PWGEM/globalDimuonFilter.cxx:189:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
EventFiltering/PWGEM/globalDimuonFilter.cxx:360:9: warning: do not use 'else' after 'return' [readability-else-after-return]
++ [[ 10 -gt 0 ]]
++ exit 1
--

Full log here.

@dsekihat
dsekihat enabled auto-merge (squash) August 27, 2026 09:13

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants