Skip to content

[Common] Q-vector correction fail safety#17035

Merged
dsekihat merged 2 commits into
AliceO2Group:masterfrom
MaximVirta:master
Jul 13, 2026
Merged

[Common] Q-vector correction fail safety#17035
dsekihat merged 2 commits into
AliceO2Group:masterfrom
MaximVirta:master

Conversation

@MaximVirta

Copy link
Copy Markdown
Contributor

Added empty histograms to avoid crashing when no correction objects are found.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for de3711f at 2026-07-13 10:06:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 19 errors and 19 warnings.'
Found 19 errors and 19 warnings.
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/c0b3b34dc35ce8a3a5127e11b6defacffefde520/O2Physics-code-check/errors.txt
Common/TableProducer/qVectorsTable.cxx:67:8: error: constructor does not initialize these fields: ccdb, fv0geom, cent [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:68:3: error: initial values in enum 'qVectorsTable::Detectors' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:167:37: error: initializer for member 'FT0RelGainConst' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:168:37: error: initializer for member 'FV0RelGainConst' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:183:15: error: member 'minAmplitude' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:187:33: error: initializer for member 'corrsQvecSp' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:188:34: error: initializer for member 'corrsQvecEse' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:189:42: error: initializer for member 'shiftProfileSp' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:190:43: error: initializer for member 'shiftProfileEse' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:395:33: error: the const qualified parameter 'track' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:429:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:595:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:596:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:597:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:598:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:599:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:600:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:601:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:781:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/c0b3b34dc35ce8a3a5127e11b6defacffefde520/O2Physics-code-check/warnings.txt
Common/TableProducer/qVectorsTable.cxx:397:36: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:399:36: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:401:32: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:403:35: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:405:32: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:407:47: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:409:35: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:411:30: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:413:29: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:857:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:859:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:861:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:863:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:865:39: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:867:39: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:869:39: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:881:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:883:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:885:37: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 19 -gt 0 ]]
++ exit 1
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 27ea0a7 at 2026-07-13 10:12:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 21 errors and 19 warnings.'
Found 21 errors and 19 warnings.
++ [[ 21 -gt 0 ]]
++ cat /sw/BUILD/a8a9740e94807432a789ef1ef51d8edde36bb6cd/O2Physics-code-check/errors.txt
Common/TableProducer/qVectorsTable.cxx:67:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:68:3: error: initial values in enum 'QVectorsTable::Detectors' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:163:37: error: initializer for member 'ft0RelGainConst' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:164:37: error: initializer for member 'fv0RelGainConst' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:179:15: error: member 'minAmplitude' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:182:13: error: member 'nShiftIndex' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:183:15: error: member 'trackEtaMin' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:185:33: error: initializer for member 'corrsQvecSp' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:186:34: error: initializer for member 'corrsQvecEse' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:187:42: error: initializer for member 'shiftProfileSp' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:188:43: error: initializer for member 'shiftProfileEse' is redundant [readability-redundant-member-init,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:393:33: error: the const qualified parameter 'track' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:427:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:593:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:594:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:595:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:596:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:597:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:598:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:599:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/qVectorsTable.cxx:779:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/a8a9740e94807432a789ef1ef51d8edde36bb6cd/O2Physics-code-check/warnings.txt
Common/TableProducer/qVectorsTable.cxx:395:36: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:397:36: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:399:32: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:401:35: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:403:32: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:405:47: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:407:35: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:409:30: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:411:29: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:855:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:857:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:859:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:861:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:863:39: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:865:39: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:867:39: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:879:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:881:37: warning: statement should be inside braces [readability-braces-around-statements]
Common/TableProducer/qVectorsTable.cxx:883:37: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@dsekihat dsekihat self-requested a review July 13, 2026 08:46
@dsekihat dsekihat merged commit 7c57fed into AliceO2Group:master Jul 13, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants