Skip to content

[Common,PWGDQ,PWGEM,PWGHF,PWGLF] Fix includes#17012

Merged
vkucera merged 2 commits into
AliceO2Group:masterfrom
vkucera:iwyu
Jul 10, 2026
Merged

[Common,PWGDQ,PWGEM,PWGHF,PWGLF] Fix includes#17012
vkucera merged 2 commits into
AliceO2Group:masterfrom
vkucera:iwyu

Conversation

@vkucera

@vkucera vkucera commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot changed the title Fix includes [Common,PWGDQ,PWGEM,PWGHF,PWGLF] Fix includes Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 138 errors, ⚠️ 233 warnings, 🔕 3 disabled

@vkucera vkucera marked this pull request as ready for review July 10, 2026 16:06
@alibuild

alibuild commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a714552 at 2026-07-10 18:22:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 279 errors and 128 warnings.'
Found 279 errors and 128 warnings.
++ [[ 279 -gt 0 ]]
++ cat /sw/BUILD/309308e8e3b3bf41d1ea9e4cd2c19ab1e65f2d03/O2Physics-code-check/errors.txt
Common/Tools/PID/pidTPCModule.h:53:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:54:1: error: included header memory is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:57:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:59:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:61:1: error: nested namespaces can be concatenated [modernize-concat-nested-namespaces,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:65:8: error: constructor does not initialize these fields: dEdxCorrected, mult, tablePIDFullEl, tablePIDFullMu, tablePIDFullPi, tablePIDFullKa, tablePIDFullPr, tablePIDFullDe, tablePIDFullTr, tablePIDFullHe, tablePIDFullAl, tablePIDTinyEl, tablePIDTinyMu, tablePIDTinyPi, tablePIDTinyKa, tablePIDTinyPr, tablePIDTinyDe, tablePIDTinyTr, tablePIDTinyHe, tablePIDTinyAl, tableTuneOnData [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:178:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:187:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:270:13: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:312:45: error: the const qualified parameter 'particle' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:389:39: error: variable 'grpo' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:393:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:408:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:414:16: error: variable 'retrieveSuccess' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:472:39: error: variable 'grpo' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:476:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:489:14: error: variable 'retrieveSuccess' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:503:9: error: variable 'input_dimensions' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:504:9: error: variable 'output_dimensions' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:604:14: error: variable 'output_network' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:752:20: error: variable 'tracksForNet_size' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:816:16: error: variable 'hadronicRate' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:817:13: error: variable 'occupancy' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:895:39: error: variable 'grpo' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:899:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:47:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:48:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:50:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:80:28: error: initializer for base class 'TObject' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:134:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:142:45: error: the parameter 'system' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:195:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:196:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:45: error: the parameter 'kfp' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:61: error: the parameter 'PV' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:274:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:275:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:295:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

dsekihat
dsekihat previously approved these changes Jul 10, 2026
View reviewed changes
@alibuild

alibuild commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b811d55 at 2026-07-10 23:33:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 279 errors and 128 warnings.'
Found 279 errors and 128 warnings.
++ [[ 279 -gt 0 ]]
++ cat /sw/BUILD/95d938afded9320369f5da661f25bfe4a2aed972/O2Physics-code-check/errors.txt
Common/Tools/PID/pidTPCModule.h:52:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:53:1: error: included header memory is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:56:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:58:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:60:1: error: nested namespaces can be concatenated [modernize-concat-nested-namespaces,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:64:8: error: constructor does not initialize these fields: dEdxCorrected, mult, tablePIDFullEl, tablePIDFullMu, tablePIDFullPi, tablePIDFullKa, tablePIDFullPr, tablePIDFullDe, tablePIDFullTr, tablePIDFullHe, tablePIDFullAl, tablePIDTinyEl, tablePIDTinyMu, tablePIDTinyPi, tablePIDTinyKa, tablePIDTinyPr, tablePIDTinyDe, tablePIDTinyTr, tablePIDTinyHe, tablePIDTinyAl, tableTuneOnData [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:177:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:186:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:269:13: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:311:45: error: the const qualified parameter 'particle' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:388:39: error: variable 'grpo' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:392:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:407:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:413:16: error: variable 'retrieveSuccess' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:471:39: error: variable 'grpo' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:475:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:488:14: error: variable 'retrieveSuccess' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:502:9: error: variable 'input_dimensions' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:503:9: error: variable 'output_dimensions' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:603:14: error: variable 'output_network' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:751:20: error: variable 'tracksForNet_size' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:815:16: error: variable 'hadronicRate' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:816:13: error: variable 'occupancy' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:894:39: error: variable 'grpo' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:898:11: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:47:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:48:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:50:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:80:28: error: initializer for base class 'TObject' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:134:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:142:45: error: the parameter 'system' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:195:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:196:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:45: error: the parameter 'kfp' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:61: error: the parameter 'PV' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:274:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:275:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:295:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@vkucera vkucera merged commit ec6f83e into AliceO2Group:master Jul 10, 2026
17 of 23 checks passed
@vkucera vkucera deleted the iwyu branch July 10, 2026 22:19
@vkucera vkucera mentioned this pull request Jul 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsekihat dsekihat dsekihat left review comments
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner
@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner
@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner
@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner
@mguilbau mguilbau Awaiting requested review from mguilbau mguilbau is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

Assignees

No one assigned

Labels

common pwgdq pwgem pwghf PWG-HF pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkucera @alibuild @dsekihat