[PWGDQ] clang-tidy bug fixes in tableMaker(MC)_withAssoc by mcoquet642 · Pull Request #16909 · AliceO2Group/O2Physics

mcoquet642 · 2026-07-03T07:49:34Z

No description provided.

github-actions · 2026-07-03T07:49:53Z

O2 linter results: ❌ 125 errors, ⚠️ 47 warnings, 🔕 0 disabled

alibuild · 2026-07-03T10:04:50Z

Error while checking build/O2Physics/code-check for 033b88c at 2026-07-03 13:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 44 errors and 0 warnings.'
Found 44 errors and 0 warnings.
++ [[ 44 -gt 0 ]]
++ cat /sw/BUILD/182661ef1038aa3358baa51117a2ef9a288e55ba/O2Physics-code-check/errors.txt
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:498:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:515:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:732:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:735:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:766:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:769:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:779:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:782:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:883:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:902:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1169:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1498:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1502:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1563:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1696:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1699:6: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:95:7: error: variable 'zorro' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:583:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:600:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:690:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:902:12: error: variable 'tvxRate' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1021:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1023:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1025:16: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1027:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1030:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1033:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1036:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1048:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1051:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1133:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1136:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1142:50: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1142:103: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1148:84: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1164:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1167:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1326:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1345:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1382:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1384:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1596:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

alibuild · 2026-07-03T16:30:11Z

Error while checking build/O2Physics/o2 for 0108fc4 at 2026-07-03 18:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/TableProducer/tableMaker_withAssoc.cxx:696:21: error: comparison of integer expressions of different signedness: 'int' and 'std::array<const char*, 5>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-07-03T16:36:27Z

Error while checking build/O2Physics/staging for 0108fc4 at 2026-07-03 18:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/TableProducer/tableMaker_withAssoc.cxx:696:21: error: comparison of integer expressions of different signedness: 'int' and 'std::array<const char*, 5>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-07-03T16:57:14Z

Error while checking build/O2Physics/code-check for 0108fc4 at 2026-07-03 18:57:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 43 errors and 0 warnings.'
Found 43 errors and 0 warnings.
++ [[ 43 -gt 0 ]]
++ cat /sw/BUILD/a122d91a2267bdb698a3eac9a92a1ffddb8aa66c/O2Physics-code-check/errors.txt
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:497:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:514:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:731:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:734:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:765:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:768:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:778:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:781:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:882:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:901:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1168:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1497:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1501:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1562:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1695:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:1698:6: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:95:7: error: variable 'zorro' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:600:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:690:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:696:21: error: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [clang-diagnostic-sign-compare,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:902:12: error: variable 'tvxRate' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1023:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1025:16: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1027:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1030:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1033:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1036:18: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1048:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1051:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1133:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1136:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1142:50: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1142:103: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1148:84: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1164:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1167:8: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1326:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1345:14: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1382:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1384:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1596:12: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:2047:10: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

…p#16909) Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

mcoquet642 added 14 commits July 1, 2026 18:22

[PWGDQ] Fixing reserved size for assocs tables in tableMaker

d90b91b

modernize-use-auto

c5524aa

modernize-use-auto

4899e1e

cppcoreguidelines-pro-type-member-init

53c306a

cppcoreguidelines-pro-bounds-array-to-pointer-decay

67b6248

cppcoreguidelines-pro-type-reinterpret-cast

801481f

readability-container-contains

7b6eb97

readability-implicit-bool-conversion

68e8fa0

readability-simplify-boolean-expr

a768134

readability-container-size-empty

7201244

modernize-avoid-c-arrays

c06df5b

fixing bug

953cdc1

performance-unnecessary-value-param

a942332

clang format

033b88c

mcoquet642 requested review from alibuild, iarsene and lucamicheletti93 as code owners July 3, 2026 07:49

github-actions Bot added the pwgdq label Jul 3, 2026

using O2 LOG instead of cout

09c8d2f

vkucera reviewed Jul 3, 2026

View reviewed changes

Comment thread PWGDQ/TableProducer/tableMaker_withAssoc.cxx Outdated

vkucera reviewed Jul 3, 2026

View reviewed changes

Comment thread PWGDQ/TableProducer/tableMaker_withAssoc.cxx Outdated

vkucera reviewed Jul 3, 2026

View reviewed changes

Comment thread PWGDQ/TableProducer/tableMaker_withAssoc.cxx Outdated

vkucera reviewed Jul 3, 2026

View reviewed changes

Comment thread PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx Outdated

mcoquet642 added 3 commits July 3, 2026 10:18

const-ref-in-for-loop (MC)

32d62ad

const-ref-in-for-loop

f60e74e

const-ref-in-process

469c759

mcoquet642 and others added 2 commits July 3, 2026 18:22

Apply suggestion from @vkucera

f3d4459

Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

Apply suggestion from @vkucera

cb98dec

Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

mcoquet642 and others added 2 commits July 3, 2026 18:22

Apply suggestion from @vkucera

a8a09b9

Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

Apply suggestion from @vkucera

0108fc4

Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

fixing casts

21672ae

extra fixes

e6251ad

fixing shadow variables/members

e46e95e

iarsene approved these changes Jul 7, 2026

View reviewed changes

iarsene merged commit c3a3c8c into AliceO2Group:master Jul 7, 2026
13 of 15 checks passed

mcoquet642 added a commit to AliceMCH/O2Physics that referenced this pull request Jul 9, 2026

[PWGDQ] clang-tidy bug fixes in tableMaker(MC)_withAssoc (AliceO2Grou…

55e2ef3

…p#16909) Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PWGDQ] clang-tidy bug fixes in tableMaker(MC)_withAssoc#16909

[PWGDQ] clang-tidy bug fixes in tableMaker(MC)_withAssoc#16909
iarsene merged 25 commits into
AliceO2Group:masterfrom
mcoquet642:dq-fixes-tm

mcoquet642 commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jul 3, 2026 •

edited

Loading

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mcoquet642 commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

alibuild commented Jul 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 3, 2026 •

edited

Loading

alibuild commented Jul 3, 2026 •

edited

Loading