[PWGLF] Initialize variables, remove unused includes and use Particle constructor#16405
Open
alcaliva wants to merge 2 commits into
Open
[PWGLF] Initialize variables, remove unused includes and use Particle constructor#16405alcaliva wants to merge 2 commits into
alcaliva wants to merge 2 commits into
Conversation
alcaliva
requested review from
HorstMa,
alibuild,
fmazzasc,
maciacco,
mpuccio,
omvazque and
skundu692
as code owners
|
O2 linter results: ❌ 0 errors, |
Collaborator
Author
Collaborator
|
Error while checking build/O2Physics/o2 for 32c219e at 2026-05-27 09:56: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 32c219e at 2026-05-27 09:57: Full log here. |
vkucera
reviewed
May 27, 2026
Comment on lines
31
to
37
| #include "Framework/AnalysisTask.h" | ||
| #include "Framework/Configurable.h" | ||
| #include "Framework/HistogramRegistry.h" | ||
| #include "Framework/InitContext.h" | ||
| #include "Framework/Logger.h" | ||
| #include "Framework/OutputObjHeader.h" | ||
| #include "Framework/runDataProcessing.h" |
Collaborator
There was a problem hiding this comment.
The problem with these is the format.
Collaborator
|
Hi @alcaliva , thanks for the fixes. I guess there was a misunderstanding in the previous PR about what to fix in the includes. |
Collaborator
Author
|
Hi @vkucera, thank you for helping me improving the code. If you have further comments I'll be happy to implement them. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.