[PWGCF] adding new analysis for multiharmonic correlations#16403
Draft
pengchon wants to merge 12 commits into
Draft
[PWGCF] adding new analysis for multiharmonic correlations#16403pengchon wants to merge 12 commits into
pengchon wants to merge 12 commits into
Conversation
added 10 commits
April 21, 2026 14:33
pengchon
requested review from
abilandz,
alibuild,
jaelpark,
otonvd,
shouqiye,
victor-gonzalez and
wenyaCern
as code owners
|
O2 linter results: ❌ 15 errors, |
github-actions
Bot
changed the title
Collaborator
Collaborator
Collaborator
|
@pengchon You did not test your changes before pushing them. |
vkucera
requested changes
May 26, 2026
Comment on lines
-18
to
28
| #include <CommonConstants/MathConstants.h> | ||
| #include <Framework/AnalysisDataModel.h> | ||
| #include <Framework/AnalysisHelpers.h> | ||
| #include <Framework/AnalysisTask.h> | ||
| #include <Framework/Configurable.h> | ||
| #include <Framework/InitContext.h> | ||
| #include <Framework/OutputObjHeader.h> | ||
| #include <Framework/DataTypes.h> | ||
| #include <Framework/runDataProcessing.h> | ||
|
|
||
| #include <TCollection.h> | ||
| #include <TFile.h> | ||
| #include <TComplex.h> | ||
| #include <TGrid.h> | ||
| #include <TH1.h> | ||
| #include <TH2.h> | ||
| #include <TList.h> | ||
| #include <TObject.h> | ||
| #include <TString.h> | ||
| #include <TH1D.h> | ||
| #include <TSystem.h> | ||
|
|
||
| #include <cstdint> | ||
| #include <cstring> |
Collaborator
There was a problem hiding this comment.
How did you come up with these changes?
vkucera
reviewed
May 26, 2026
Collaborator
There was a problem hiding this comment.
I see 39 new statements in this file and zero delete statements. If you decide to use dynamic allocation, you have to handle the memory properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.