Skip to content

[PWGCF] nchCumulantsId: Make axes configurable#16368

Merged
SwatiSaha-1997 merged 32 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3
May 27, 2026
Merged

[PWGCF] nchCumulantsId: Make axes configurable#16368
SwatiSaha-1997 merged 32 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3

Conversation

@pravatp98
Copy link
Copy Markdown
Contributor

Configurable bins added

Removed commented-out code for various track quality assessment functions and their calls, streamlining the nchCumulantsId.cxx file.
Removed unused variables related to electron and deuteron track identification.
additional Event cuts has been added
additional checks has been added
Additional checks has been added
Additional checks has been added
Removed unused variables related to electron and deuteron track identification.
Added configurable rejection cuts for PID selection and updated histogram registration for PID validation.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Net charge fluctuations3 [PWGCF] Net charge fluctuations3 May 25, 2026
@pravatp98
Copy link
Copy Markdown
Contributor Author

Dear @SwatiSaha-1997 @victor-gonzalez
I have added some checks to code. Kindly review and approve the PR
Thanks and Regards
Pravata

@SwatiSaha-1997
Copy link
Copy Markdown
Collaborator

@pravatp98, even if the PR is approved by reviewers, it will not be merged as [build/O2Physics/o2/macOS-arm] failed which is mandatory. Please see if that can be fixed.
Also correct the headers in PR #16229 (see comments)

@pravatp98
Copy link
Copy Markdown
Contributor Author

Dear @SwatiSaha-1997 ,
the headers are now corrected (i have attached a screenshot of it)
Screenshot from 2026-05-26 09-31-13

and the macOs-arm error doesn't seem to be coming from my task. Anton Alkin replied to the error query that the error was the issue of the O2 framework. Here is the link.
https://mattermost.web.cern.ch/alice/pl/3r557mhidfnjxke8hny9c6yz5c

Kindly please approve my PR.

Best Regards,
Pravata

@pravatp98
Copy link
Copy Markdown
Contributor Author

Dear @SwatiSaha-1997
I guess all checks have passed. Kindly approve the PR
Thanks and Regards
Pravata

Copy link
Copy Markdown
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @SwatiSaha-1997 , the headers are now corrected

No, they are not. The current version of the PR does not touch the includes at all.

@pravatp98 pravatp98 requested a review from vkucera May 26, 2026 11:52
Comment thread PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx Outdated
@vkucera vkucera changed the title [PWGCF] Net charge fluctuations3 [PWGCF] nchCumulantsId: Make axes configurable May 26, 2026
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 26, 2026

@pravatp98 Please use meaningful PR titles. "Net charge fluctuations3" does not tell me anything about what you did.

pravatp98 and others added 3 commits May 27, 2026 11:25
pravatp98 added 2 commits May 27, 2026 12:10
…Headers added

Required headers added also configurable axis added to the analysis
Please consider the following formatting changes to AliceO2Group#16368
Comment thread PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx
Comment thread PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx Outdated
@SwatiSaha-1997 SwatiSaha-1997 requested a review from vkucera May 27, 2026 12:39
@SwatiSaha-1997 SwatiSaha-1997 enabled auto-merge (squash) May 27, 2026 13:30
@SwatiSaha-1997 SwatiSaha-1997 merged commit 8f3f8b2 into AliceO2Group:master May 27, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants