[PWGHF] Add UPC event selection by zhangbiao-phy · Pull Request #11518 · AliceO2Group/O2Physics

zhangbiao-phy · 2025-06-09T11:06:12Z

Add UPC event selection into the HF framework, the preselection used taken from UD group, further selection (ZDC or ITs UPC mode) can be easily added into specific task:

Implement SGSelector cut from PWGUD
Add rejection bit into rejection mask
Add QA plot for the type of single gap A/C, double gap trigger event

Main changes are in trackIndexSkimCreator.cxx and utilsEvSelHf.h

github-actions · 2025-06-09T11:06:31Z

O2 linter results: ❌ 20 errors, ⚠️ 0 warnings, 🔕 47 disabled

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

Please consider the following formatting changes to AliceO2Group#11518

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

alibuild · 2025-06-09T15:20:02Z

Error while checking build/O2Physics/o2 for 71fc7b5 at 2025-06-09 17:20:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
collect2: error: ld returned 1 exit status
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

mfaggin · 2025-06-09T16:12:55Z

PWGHF/Utils/utilsEvSelHf.h

  o2::framework::Configurable<float> centralityMin{"centralityMin", 0., "Minimum centrality"};
  o2::framework::Configurable<float> centralityMax{"centralityMax", 100., "Maximum centrality"};
  o2::framework::Configurable<bool> useSel8Trigger{"useSel8Trigger", true, "Apply the sel8 event selection"};
+  o2::framework::Configurable<bool> useUpcTrigger{"useUpcTrigger", true, "Apply the upc event selection"};


Suggested change

o2::framework::Configurable<bool> useUpcTrigger{"useUpcTrigger", true, "Apply the upc event selection"};

o2::framework::Configurable<bool> useUpcTrigger{"useUpcTrigger", false, "Apply the upc event selection"};

I'd not enable it by default

Thanks for spoting this

PWGHF/Tasks/taskPidStudies.cxx

mfaggin · 2025-06-09T16:21:04Z

PWGHF/Tasks/taskMcValidation.cxx

                          aod::McParticles const& mcParticles,
                          aod::McCollisions const& mcCollisions,
-                          aod::BCsWithTimestamps const& bcs,
+                          BCsInfo const& bcs,


I'd call the BCsInfo data type if and only if UPC selections are enabled. This means that in the process functions that do not apply UPC selections I'd not use at all the data type BCsInfo, but I'd keep the data type aod::BCsWithTimestamps

PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx

PWGHF/D2H/Tasks/taskFlowCharmHadrons.cxx

PWGHF/TableProducer/candidateCreator2Prong.cxx

PWGHF/TableProducer/trackIndexSkimCreator.cxx

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

Please consider the following formatting changes to AliceO2Group#11518

zhangbiao-phy · 2025-06-24T12:33:06Z

hi @vkucera, thanks for the comments! I fixed all of them. Could you take a look? Thanks!

You still use useUpcSel and applyUpcSel.

I didn't get your point before, I fixed it now

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

PWGHF/DataModel/CandidateReconstructionTables.h

PWGHF/TableProducer/candidateCreator2Prong.cxx

PWGHF/TableProducer/candidateCreator3Prong.cxx

PWGHF/TableProducer/trackIndexSkimCreator.cxx

PWGHF/Utils/utilsEvSelHf.h

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

vkucera · 2025-06-26T14:34:03Z

@mfaggin @fgrosa Can you also check if it looks good to you?

fgrosa · 2025-06-27T08:16:34Z

@mfaggin @fgrosa Can you also check if it looks good to you?

Good for me! I would suggest to move on and merge

zhangbiao-phy · 2025-06-27T08:16:59Z

@mfaggin @fgrosa Can you also check if it looks good to you?

Good for me! I would suggest to move on and merge

Thanks all!

github-actions bot added the pwghf PWG-HF label Jun 9, 2025

alibuild mentioned this pull request Jun 9, 2025

[PWGHF] Please consider the following formatting changes to #11518 zhangbiao-phy/O2Physics#40

Merged

zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 9, 2025

Merge pull request #40 from alibuild/alibot-cleanup-11518

88ba97e

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

zhangbiao-phy force-pushed the master branch from 88ba97e to e975fc8 Compare June 9, 2025 11:46

alibuild mentioned this pull request Jun 9, 2025

[PWGHF] Please consider the following formatting changes to #11518 zhangbiao-phy/O2Physics#41

Merged

zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 9, 2025

Merge pull request #41 from alibuild/alibot-cleanup-11518

624059a

Please consider the following formatting changes to AliceO2Group#11518

zhangbiao-phy force-pushed the master branch from 624059a to 8a3834c Compare June 9, 2025 11:53

alibuild mentioned this pull request Jun 9, 2025

[PWGHF] Please consider the following formatting changes to #11518 zhangbiao-phy/O2Physics#42

Merged

zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 9, 2025

Merge pull request #42 from alibuild/alibot-cleanup-11518

71fc7b5

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

zhangbiao-phy marked this pull request as ready for review June 9, 2025 11:58

zhangbiao-phy requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, fgrosa, gluparel, hahassan7, jpxrk, mfaggin, mmazzilli and vkucera as code owners June 9, 2025 11:58

zhangbiao-phy force-pushed the master branch from 71fc7b5 to 6b09aff Compare June 9, 2025 15:59

alibuild mentioned this pull request Jun 9, 2025

[PWGHF] Please consider the following formatting changes to #11518 zhangbiao-phy/O2Physics#43

Merged

zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 9, 2025

Merge pull request #43 from alibuild/alibot-cleanup-11518

ead0914

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

mfaggin reviewed Jun 9, 2025

View reviewed changes

vkucera requested changes Jun 9, 2025

View reviewed changes

alibuild mentioned this pull request Jun 24, 2025

[PWGHF] Please consider the following formatting changes to #11518 zhangbiao-phy/O2Physics#57

Merged

zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 24, 2025

Merge pull request #57 from alibuild/alibot-cleanup-11518

8416443

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518

fix comments from typo

0899aa2

zhangbiao-phy force-pushed the master branch from 8416443 to 0899aa2 Compare June 24, 2025 11:48

alibuild mentioned this pull request Jun 24, 2025

[PWGHF] Please consider the following formatting changes to #11518 zhangbiao-phy/O2Physics#58

Merged

zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 24, 2025

Merge pull request #58 from alibuild/alibot-cleanup-11518

9d1d8e0

Please consider the following formatting changes to AliceO2Group#11518

zhangbiao-phy requested a review from vkucera June 25, 2025 06:57

fix comments from vit

1b7ce84

zhangbiao-phy force-pushed the master branch from 9d1d8e0 to 1b7ce84 Compare June 25, 2025 12:31

alibuild mentioned this pull request Jun 25, 2025

[PWGHF] Please consider the following formatting changes to #11518 zhangbiao-phy/O2Physics#59

Merged

zhangbiao-phy added a commit to zhangbiao-phy/O2Physics that referenced this pull request Jun 25, 2025

Merge pull request #59 from alibuild/alibot-cleanup-11518

11a643d

[PWGHF] Please consider the following formatting changes to AliceO2Group#11518