OCTRL-1078 Make Task Controller able to control OCC tasks#804
OCTRL-1078 Make Task Controller able to control OCC tasks#804justonedev1 wants to merge 5 commits intomasterfrom
Conversation
knopers8
left a comment
There was a problem hiding this comment.
thanks! I did not try to run it yet, but I already have some questions/suggestions.
| - O2_PARTITION={{ environment_id }} | ||
| user: "{{ user }}" | ||
| arguments: | ||
| - "/root/readout.yaml" |
There was a problem hiding this comment.
why is the manifest file added as an argument to readout?
There was a problem hiding this comment.
it is described in the documentation, basically it is a scaffold to let the executor know which manifest to load. You can see it inside the KubectlTask in other PR
There was a problem hiding this comment.
indeed, saw it there, clear. perhaps you could add a yaml comment to avoid confusion.
control-operator/ecs-manifests/control-workflows/stfbuilder-senderoutput-kube.yaml
Show resolved
Hide resolved
| @@ -0,0 +1,69 @@ | |||
| apiVersion: aliecs.alice.cern/v1alpha1 | |||
There was a problem hiding this comment.
Perhaps this and the other manifest in this directory could be moved to ecs-manifests.
There was a problem hiding this comment.
this is leftover
There was a problem hiding this comment.
do you plan to remove it then?
introduction of controller for kubernetes inside the controller-operator folder.
This version allows us to control all OCC tasks (tested on readout, stfsender and stfbuilder). Currently there is not image and controller was run directly via
make runon the node where the kubernetes cluster is running. If you run it locally and cluster is on different computer, you would not be able to communicate with OCC process as these require opened portsManifests required to run these tasks are inside the
ecs-manifestssubfolder.In order to apply these manifests use
kubectl. There is an explanation which file is which inside thekubernetes-ecs.md.