Wrap the QED event IDs at the number of QED events available - #15715
Merged
Conversation
This fixes a problem in the QED round robin of the collision context and adds a guard in the MCKinematicsReader. - o2-steer-colcontexttool passed the number of MC events asked to fillQED, so the round robin never wrapped and the QED event parts named events which are not in the QED kinematics. - The number of events available is used now, with a warning when it is missing or larger than an MCEventLabel can encode. - MCKinematicsReader read past the end of its header, track and track-reference vectors for such an event ID. It throws std::out_of_range now, and the getters returning a pointer or a span report the miss instead. - The range test shares the branch of the lazy load and the message is built out of line, so the accessors keep their fast path. https://its.cern.ch/jira/browse/O2-7132
shahor02
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem in the QED round robin of the collision context and adds a guard in the MCKinematicsReader.
https://its.cern.ch/jira/browse/O2-7132