Skip to content

MC-RECO: Ability to process empty timeframes (Part 2) #15714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sawenzel wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

MC-RECO: Ability to process empty timeframes (Part 2) #15714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5beaad5
Let the digit readers accept a timeframe without collisions
sawenzel Aug 24, 2026
dc8f978
Check for the end of the tree where the reader specs asserted it
sawenzel Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Detectors/CPV/workflow/src/ClusterReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,16 @@ void ClusterReader::init(InitContext& ic)
void ClusterReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "Pushing " << mClusters.size() << " Clusters in " << mTRs.size() << " TriggerRecords at entry " << ent;
pc.outputs().snapshot(Output{mOrigin, "CLUSTERS", 0}, mClusters);
Expand Down
11 changes: 10 additions & 1 deletion Detectors/CPV/workflow/src/DigitReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,16 @@ void DigitReader::init(InitContext& ic)
void DigitReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "Pushing " << mDigits.size() << " Digits in " << mTRs.size() << " TriggerRecords at entry " << ent;
pc.outputs().snapshot(Output{mOrigin, "DIGITS", 0}, mDigits);
Expand Down
11 changes: 10 additions & 1 deletion Detectors/CTP/workflowIO/src/DigitReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,16 @@ void DigitReader::run(ProcessingContext& pc)
auto ent = mTree->GetReadEntry();
if (!mUseIRFrames) {
ent++;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "DigitReader pushes " << mDigits.size() << " digits at entry " << ent;
pc.outputs().snapshot(Output{"CTP", "DIGITS", 0}, mDigits);
Expand Down
11 changes: 10 additions & 1 deletion Detectors/FIT/FDD/workflow/src/DigitReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,16 @@ void DigitReader::run(ProcessingContext& pc)
}
}
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);

LOG(info) << "FDD DigitReader pushes " << digitsBC->size() << " digits";
Expand Down
11 changes: 10 additions & 1 deletion Detectors/FIT/FDD/workflow/src/RecPointReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,16 @@ void RecPointReader::init(InitContext& ic)
void RecPointReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);

LOG(info) << "FDD RecPointReader pushes " << mRecPoints->size() << " recpoints with " << mChannelData->size() << " channels at entry " << ent;
Expand Down
11 changes: 10 additions & 1 deletion Detectors/FIT/FT0/workflow/src/DigitReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,16 @@ void DigitReader::run(ProcessingContext& pc)
mTree->SetBranchAddress("FT0DIGITSMCTR", &plabels);
}
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(debug) << "FT0DigitReader pushed " << channels.size() << " channels in " << digits.size() << " digits";
pc.outputs().snapshot(Output{"FT0", "DIGITSBC", 0}, digits);
Expand Down
11 changes: 10 additions & 1 deletion Detectors/FIT/FT0/workflow/src/RecPointReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,16 @@ void RecPointReader::init(InitContext& ic)
void RecPointReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);

LOG(debug) << "FT0 RecPointReader pushes " << mRecPoints->size() << " recpoints with " << mChannelData->size() << " channels at entry " << ent;
Expand Down
11 changes: 10 additions & 1 deletion Detectors/FIT/FV0/workflow/src/DigitReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,16 @@ void DigitReader::run(ProcessingContext& pc)
mTree->SetBranchAddress("FV0DigitLabels", &plabels);
}
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(debug) << "FV0DigitReader pushed " << channels.size() << " channels in " << digits.size() << " digits";
pc.outputs().snapshot(Output{"FV0", "DIGITSBC", 0}, digits);
Expand Down
11 changes: 10 additions & 1 deletion Detectors/FIT/FV0/workflow/src/RecPointReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,16 @@ void RecPointReader::init(InitContext& ic)
void RecPointReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);

LOG(debug) << "FV0 RecPointReader pushes " << mRecPoints->size() << " recpoints with " << mChannelData->size() << " channels at entry " << ent;
Expand Down
11 changes: 10 additions & 1 deletion Detectors/Filtering/src/FilteredTFReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,16 @@ void FilteredTFReader::run(ProcessingContext& pc)
// FIXME: fill all output headers by TF specific info (extend findMessageHeaderStack)

auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);

LOG(info) << "Pushing filtered TF: " << mFiltTF.header.asString();
Expand Down
11 changes: 10 additions & 1 deletion Detectors/GlobalTrackingWorkflow/readers/src/GlobalFwdTrackReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,16 @@ void GlobalFwdTrackReader::init(InitContext& ic)
void GlobalFwdTrackReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "Pushing " << mTracks.size() << " Global Forward tracks at entry " << ent;

Expand Down
11 changes: 10 additions & 1 deletion Detectors/GlobalTrackingWorkflow/readers/src/IRFrameReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,16 @@ void IRFrameReaderSpec::init(InitContext& ic)
void IRFrameReaderSpec::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(debug) << "Pushing " << mIRF.size() << " IR-frames in at entry " << ent;
pc.outputs().snapshot(Output{mDataOrigin, "IRFRAMES", mSubSpec}, mIRF);
Expand Down
11 changes: 10 additions & 1 deletion Detectors/GlobalTrackingWorkflow/readers/src/MatchedMCHMIDReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,16 @@ void MatchMCHMIDReader::init(InitContext& ic)
void MatchMCHMIDReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "Pushing " << mTracks.size() << " MCHMID matches at entry " << ent;

Expand Down
11 changes: 10 additions & 1 deletion Detectors/GlobalTrackingWorkflow/readers/src/MatchedMFTMCHReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,16 @@ void MatchMFTMCHReader::init(InitContext& ic)
void MatchMFTMCHReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "Pushing " << mTracks.size() << " MFTMCH matches at entry " << ent;

Expand Down
11 changes: 10 additions & 1 deletion Detectors/GlobalTrackingWorkflow/readers/src/PrimaryVertexReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,16 @@ void PrimaryVertexReader::init(InitContext& ic)
void PrimaryVertexReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "Pushing " << mVerticesPtr->size() << " vertices at entry " << ent;

Expand Down
11 changes: 10 additions & 1 deletion Detectors/GlobalTrackingWorkflow/readers/src/SecondaryVertexReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,16 @@ void SecondaryVertexReader::init(InitContext& ic)
void SecondaryVertexReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOGP(info, "Pushing {} V0s ({} indices), {} cascades ({} indices) and {} 3-body ({} indices ) at entry {}",
mV0s.size(), mV0sIdx.size(), mCascs.size(), mCascsIdx.size(), m3Bodys.size(), m3BodysIdx.size(), ent);
Expand Down
11 changes: 10 additions & 1 deletion Detectors/GlobalTrackingWorkflow/readers/src/StrangenessTrackingReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,16 @@ void StrangenessTrackingReader::init(InitContext& ic)
void StrangenessTrackingReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "Pushing " << mStrangeTrack.size() << " strange tracks at entry " << ent;
pc.outputs().snapshot(Output{"GLO", "STRANGETRACKS", 0}, mStrangeTrack);
Expand Down
11 changes: 10 additions & 1 deletion Detectors/GlobalTrackingWorkflow/readers/src/TrackCosmicsReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,16 @@ void TrackCosmicsReader::init(InitContext& ic)
void TrackCosmicsReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "Pushing " << mTracks.size() << " Cosmic Tracks at entry " << ent;

Expand Down
11 changes: 10 additions & 1 deletion Detectors/GlobalTrackingWorkflow/readers/src/TrackTPCITSReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,16 @@ void TrackTPCITSReader::init(InitContext& ic)
void TrackTPCITSReader::run(ProcessingContext& pc)
{
auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);
LOG(info) << "Pushing " << mTracks.size() << " TPC-ITS matches at entry " << ent;

Expand Down
11 changes: 10 additions & 1 deletion Detectors/HMPID/workflow/src/ClustersReaderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,16 @@ void ClusterReaderTask::run(ProcessingContext& pc)
{

auto ent = mTree->GetReadEntry() + 1;
assert(ent < mTree->GetEntries()); // this should not happen
if (ent >= mTree->GetEntries()) {
// A timeframe holds no collision at all whenever the interaction rate is low enough, and
// the tree then has no entry to read. End the stream instead of reading past the end and
// publishing branch addresses that GetEntry has not filled. This was an assert, which is
// compiled out of every production build since ENABLE_CASSERT defaults to OFF.
LOG(info) << "no entry to read, ending the stream";
pc.services().get<ControlService>().endOfStream();
pc.services().get<ControlService>().readyToQuit(QuitRequest::Me);
return;
}
mTree->GetEntry(ent);

pc.outputs().snapshot(Output{"HMP", "CLUSTERS", 0}, mClustersFromFile);
Expand Down
Loading