fix wrong long_to_int converstion in TOF readout window indexing#15265
Merged
shahor02 merged 1 commit intoAliceO2Group:devfrom Apr 9, 2026
Merged
fix wrong long_to_int converstion in TOF readout window indexing#15265shahor02 merged 1 commit intoAliceO2Group:devfrom
shahor02 merged 1 commit intoAliceO2Group:devfrom
Conversation
noferini
force-pushed
the
dev
branch
2 times, most recently
from
68e6a89 to
eb556a7
Compare
shahor02
previously approved these changes
Apr 9, 2026
shahor02
approved these changes
Apr 9, 2026
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Build CIs were passed, merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @ehellbar ,
I fixed two lines with bad conversion from long to int.
Indeed, even if orbit is "int", when multiplying by 3 it can get "long".
Thanks for spotting the problem.
Cheers,
Francesco