Skip to content

DPL: trigger runtime error in case of duplicate processor names #13963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehellbar wants to merge 3 commits into from
Closed

DPL: trigger runtime error in case of duplicate processor names #13963

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eef5e2c
DPL: trigger runtime error in case of duplicate processor names
ehellbar Feb 13, 2025
841b74a
simplifying logic and accounting for multiple pipelines
ehellbar Feb 18, 2025
914bfa1
going back to original implementation with DataProcessorSpec and usin…
ehellbar Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Framework/Core/src/runDataProcessing.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2959,7 +2959,11 @@ int doMain(int argc, char** argv, o2::framework::WorkflowSpec const& workflow,
for (auto& dp : importedWorkflow) {
auto found = std::find_if(physicalWorkflow.begin(), physicalWorkflow.end(),
[&name = dp.name](DataProcessorSpec const& spec) { return spec.name == name; });
if (found == physicalWorkflow.end()) {
// also checking the workflow for processors with the same name but from a different executable,
Copy link
Copy Markdown
Member

@ktf ktf Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two find_if statements?

Copy link
Copy Markdown
Collaborator Author

@ehellbar ehellbar Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point :)

// adding them to the workflow to trigger the check for duplicate names in the MATERIALISE_WORKFLOW state
auto duplicate_name = std::find_if(dataProcessorInfos.begin(), dataProcessorInfos.end(),
[&name = dp.name, &exec = currentWorkflow.executable](DataProcessorInfo const& info) { return (info.name == name && info.executable != exec); });
if (found == physicalWorkflow.end() || duplicate_name != dataProcessorInfos.end()) {
physicalWorkflow.push_back(dp);
rankIndex.insert(std::make_pair(dp.name, workflowHashB));
}
Expand Down