PrimaryGen: More consistent vertex configuration#13955
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Feb 11, 2025
Merged
PrimaryGen: More consistent vertex configuration#13955sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel merged 1 commit intoAliceO2Group:devfrom
Conversation
* do not apply a vertex when the mode is kNoVertex (this was buggy) * introduce a new vertex mode kCollContext to indicate the the vertex is to be taken from a collision context
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
sawenzel
added a commit
to sawenzel/O2DPG
that referenced
this pull request
Feb 11, 2025
This goes together with AliceO2Group/AliceO2#13955 and ensures a more consistent primary vertex location during the event generator phases in O2DPG MC. Fixes a bug where the primary vertex was applied twice.
jackal1-66
approved these changes
Feb 11, 2025
sawenzel
added a commit
to AliceO2Group/O2DPG
that referenced
this pull request
Feb 11, 2025
This goes together with AliceO2Group/AliceO2#13955 and ensures a more consistent primary vertex location during the event generator phases in O2DPG MC. Fixes a bug where the primary vertex was applied twice.
alcaliva
pushed a commit
to AliceO2Group/O2DPG
that referenced
this pull request
Feb 12, 2025
This goes together with AliceO2Group/AliceO2#13955 and ensures a more consistent primary vertex location during the event generator phases in O2DPG MC. Fixes a bug where the primary vertex was applied twice. (cherry picked from commit 7340626)
alcaliva
pushed a commit
to AliceO2Group/O2DPG
that referenced
this pull request
Feb 12, 2025
This goes together with AliceO2Group/AliceO2#13955 and ensures a more consistent primary vertex location during the event generator phases in O2DPG MC. Fixes a bug where the primary vertex was applied twice. (cherry picked from commit 7340626)
alcaliva
pushed a commit
to AliceO2Group/O2DPG
that referenced
this pull request
Feb 12, 2025
This goes together with AliceO2Group/AliceO2#13955 and ensures a more consistent primary vertex location during the event generator phases in O2DPG MC. Fixes a bug where the primary vertex was applied twice. (cherry picked from commit 7340626)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not apply a vertex when the mode is kNoVertex (this was buggy)
introduce a new vertex mode kCollContext to indicate the the vertex is to be taken from a collision context