fix: correct pip install order so VLSearchImage is registered (fixes #234)#253
Open
octo-patch wants to merge 1 commit intoAlibaba-NLP:mainfrom
Open
fix: correct pip install order so VLSearchImage is registered (fixes #234)#253octo-patch wants to merge 1 commit intoAlibaba-NLP:mainfrom
octo-patch wants to merge 1 commit intoAlibaba-NLP:mainfrom
Conversation
…libaba-NLP#234) The previous install sequence uninstalled qwen-agent, installed the local vl_search_r1/qwen-agent-o1_search (which provides VLSearchImage), and then reinstalled the standard qwen-agent from PyPI — overwriting the local version and removing VLSearchImage from TOOL_REGISTRY. Reversed the order: install qwen-agent[code_interpreter] first (to pull in all required dependencies), then install the local fork in editable mode --no-deps so VLSearchImage remains available when agent_eval.py runs. Co-Authored-By: Octopus <liyuan851277048@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #234
Problem
The
eval.shscript installs packages in the wrong order, causingVLSearchImageto be absent fromTOOL_REGISTRYwhenagent_eval.pyruns:Because
pip install "qwen-agent[code_interpreter]"replaces the editable local install,VLSearchImageis no longer inTOOL_REGISTRY. WhenQwen_agentis then instantiated withfunction_list=['web_search', 'VLSearchImage', 'visit', 'code_interpreter'], qwen-agent raises:Solution
Reverse the install order so the local fork (which adds
VLSearchImage) is installed after the PyPI package has already pulled in all dependencies:The
pip uninstall qwen-agentstep is also removed as it is unnecessary —pip installalready replaces an existing installation.Testing
Verified the
eval.shdiff is minimal (3-line change) and that the install sequence now ends with the local fork active, ensuringVLSearchImageis inTOOL_REGISTRYwhenagent_eval.pyinitialisesQwen_agent.