fix: skip temperature param for OpenAI reasoning/newer models in summary tool#252
Open
octo-patch wants to merge 1 commit intoAlibaba-NLP:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211
Problem
When using newer OpenAI models (o1, o3, o4 reasoning models, gpt-5, etc.) as the summary model (
SUMMARY_MODEL_NAME), thecall_servermethod in bothinference/tool_visit.pyandWebAgent/WebResummer/src/tool_visit.pyunconditionally passestemperature=0.7. These model families do not support thetemperatureparameter and will return an API error.Solution
Before building the API call kwargs, check whether the model name starts with a prefix known to not support temperature (
o1,o3,o4,gpt-5). Only includetemperaturein the request when the model supports it.Files changed
inference/tool_visit.py—Visit.call_server()WebAgent/WebResummer/src/tool_visit.py—Visit.call_server()Testing
Tested locally by setting
SUMMARY_MODEL_NAME=o1-miniand verifying notemperatureis passed; and withSUMMARY_MODEL_NAME=gpt-4oto confirmtemperature=0.7is still included for standard models.