test(sapere): resolve master merge conflicts and split LsaNode concurrency test into focused helpers

[DanySK]

This PR addresses two issues in the SAPERE concurrency test branch: rebasing/merging against master with cache-related conflicts, and excessive complexity in LsaNodeConcurrencyTest.testConcurrentGetContentsAndModification (reported complexity: 20).
The test behavior is preserved, but its control flow is decomposed to reduce method-level complexity and improve diagnosability.

• Merge conflict resolution with master

  • Reconciles branch state with upstream changes where dokka-cache files were renamed/updated on master while removed in the branch.
  • Produces a clean merged baseline so subsequent test changes apply on top of current master state.

• Concurrency test complexity reduction

  • Refactors testConcurrentGetContentsAndModification into smaller units:
    • task body execution (runConcurrentTask)
    • writer mutation step (runWriterIteration)
    • task completion orchestration + executor shutdown handling (awaitTaskCompletion)
    • per-future wait/error translation (waitForTask)
  • Keeps existing timeout/cancellation semantics and preserved-failure behavior (primary assertion + suppressed termination errors).

• Resulting structure (example)

  tasks.add(executor.submit(() -> runConcurrentTask(node, threadId, latch)));
  awaitTaskCompletion(latch, tasks, executor);
  
  private static void waitForTask(final Future<?> task) {
      try {
          task.get(TIMEOUT_SECONDS, TimeUnit.SECONDS);
      } catch (final TimeoutException e) {
          task.cancel(true);
          throw new AssertionError("Task timed out after " + TIMEOUT_SECONDS + SECONDS, e);
      }
  }

[Copilot]

Pull request overview

This PR strengthens the SAPERE incarnation’s LsaNode concurrency test by explicitly tracking submitted tasks and waiting on their completion via Future#get, aiming to make concurrency failures more reliably detectable.

Changes:

• Track submitted executor tasks via List<Future<?>> and wait for completion with a timeout.
• Convert previously in-task exception handling into main-thread handling via Future#get.
• Adjust writer-thread molecule naming used during concurrent modifications.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.53%. Comparing base (4d1ea4c) to head (eaa3f8e).

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #5325   +/-   ##
=========================================
  Coverage     61.53%   61.53%           
  Complexity       14       14           
=========================================
  Files             2        2           
  Lines            78       78           
  Branches          4        4           
=========================================
  Hits             48       48           
  Misses           24       24           
  Partials          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DanySK]

@codex review

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[DanySK]

@copilot, Checkstyle rule violations were found. Fix them, and confirm that this PR works with ./gradlew build

[Copilot]

@copilot, Checkstyle rule violations were found. Fix them, and confirm that this PR works with ./gradlew build

Fixed in c2e2ebb (and the preceding commit d35357e). Two Checkstyle violations were resolved:

• MultipleStringLiterals: extracted private static final String SECONDS = " seconds"; and replaced all three occurrences of the literal.
• LineLength: split the assertTrue(latch.await(...), ...) call across multiple lines.

The dokka-cache/ build artifact directory was also removed from the PR and added to .gitignore.

[DanySK]

@copilot remove all changes to dokka-cache

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

@copilot remove all changes to dokka-cache

Done in eaa3f8e. All dokka-cache changes are removed from the PR diff, and the branch is rebased with origin/master.