PRA05-AlberteMartinez-InheritanceAndAbstraction#28
Open
AlberteMB wants to merge 7 commits intoAlbertProfe:masterfrom
Open
PRA05-AlberteMartinez-InheritanceAndAbstraction#28AlberteMB wants to merge 7 commits intoAlbertProfe:masterfrom
AlberteMB wants to merge 7 commits intoAlbertProfe:masterfrom
Conversation
First steps in test for superclass and subclasses.
Adding new services. MenuItemSuperclass test: Passed!
- DataLoader adding new faker for each subclass Dessert and MainCourse. - Adding empty constructor in MainCourse and Dessert for testing via Swagger. - Adding JsonIgnore in superclass MenuItem to focus only in subclasses via Swagger. - Adding JsonTypeInfo and JsonSubTypes to decide which subclass is been generated via Swagger (Type="dessert" or Type="mainCourse" needed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controllers: In the MenuItemController, I handle the creation of both subclasses (Dessert and MainCourse). By using the annotations @JsonTypeInfo and @JsonSubTypes, I only need to specify the Type field in each "PUT" request via Swagger.
DataLoader: Each subclass is created with its own specific attributes.
Test: Verifying if methods from the MenuItem interface can be used effectively in each subclass.