Revert commit that broke digital bindings to analog axis.#7
Open
Nomagno wants to merge 1 commit intoAlayan-stk-2:BalanceSTK2from
Open
Revert commit that broke digital bindings to analog axis.#7Nomagno wants to merge 1 commit intoAlayan-stk-2:BalanceSTK2from
Nomagno wants to merge 1 commit intoAlayan-stk-2:BalanceSTK2from
Conversation
This reverts commit dd464af.
|
I confirm this issue and the fix provided by nomagno is working fine on TME. Issue still happening on main STK2 and makes controller use very complicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dd464af.
Strictly speaking, reverting this commit fixes the issue with no side effects but it is not completely clear why that code did NOT cause this issue in the first place. Other solutions might be worth looking into.
Explained fairly well in Nomagno#27
The "edit" section was just because releasing accel makes the kart not consume nitro, nothing to do.
This issue also affects binding look back, brake, or any other digital action to an analog axis That has its resting position as fully negative, and its fully pressed position to fully positive.
Steps to reproduce:
With a controller, bind e.g. "look back" to analog right trigger, or "nitro", whatever really. Once you press it once, it is now (almost) impossible to get the game to stop doing the action. The only way is to get the trigger to be EXACTLY 0 by pressing it exactly halfway, which isn't that hard but is a completely broken way to play.
Agreement