Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 23 additions & 13 deletions src/84from.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,22 +153,32 @@ alasql.from.JSON = function (filename, opts, cb, idx, query) {
//console.log('cb',cb);
//console.log('JSON');
filename = alasql.utils.autoExtFilename(filename, 'json', opts);
(alasql.utils.loadFile(filename, !!cb, function (data) {
// console.log('DATA:'+data);
// res = [{a:1}];
res = JSON.parse(data);
if (cb) {
res = cb(res, idx, query);
const errorHandler = err => {
const error = err instanceof Error ? err : new Error(err);
if (query && query.cb) {
query.cb(null, error);
return;
}
}),
err => {
const error = err instanceof Error ? err : new Error(err);
if (query && query.cb) {
query.cb(null, error);
throw error;
};
alasql.utils.loadFile(
filename,
!!cb,
function (data) {
// console.log('DATA:'+data);
// res = [{a:1}];
try {
res = JSON.parse(data);
} catch (error) {
errorHandler(error);
return;
}
throw error;
});
if (cb) {
res = cb(res, idx, query);
}
},
errorHandler
);
return res;
};

Expand Down
1 change: 1 addition & 0 deletions test/test1314-invalid.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
invalid JSON
37 changes: 37 additions & 0 deletions test/test1314.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
if (typeof exports === 'object') {
var assert = require('assert');
var alasql = require('..');
} else {
__dirname = '.';
}

describe('Test 1314 - JSON file errors', function () {
it('1. Rejects when the JSON file does not exist', async function () {
await assert.rejects(
alasql(['SELECT * FROM JSON("' + __dirname + '/test1314-missing.json")']),
function (error) {
return error instanceof Error && error.code === 'ENOENT';
}
);
});

it('2. Passes missing file errors to the query callback', function (done) {
alasql(
'SELECT * FROM JSON("' + __dirname + '/test1314-missing.json")',
[],
function (result, error) {
assert.strictEqual(result, null);
assert(error instanceof Error);
assert.strictEqual(error.code, 'ENOENT');
done();
}
);
});

it('3. Rejects when the JSON file is invalid', async function () {
await assert.rejects(
alasql(['SELECT * FROM JSON("' + __dirname + '/test1314-invalid.txt")']),
SyntaxError
);
});
});