Add \r and \f as separators for shell commands

aikido_zen/vulnerabilities/shell_injection/contains_shell_syntax.py

@@ -30,6 +30,8 @@
     "\n",
     "\t",
     "~",
+    "\r",
+    "\f",
 ]
 
 commands = [
@@ -105,7 +107,7 @@
     "/usr/local/sbin/",
 ]
 
-separators = [" ", "\t", "\n", ";", "&", "|", "(", ")", "<", ">"]
+separators = [" ", "\t", "\n", ";", "&", "|", "(", ")", "<", ">", "\r", "\f"]
 
 
 # Function to sort commands by length (longer commands first)

aikido_zen/vulnerabilities/shell_injection/contains_shell_syntax_test.py

@@ -137,3 +137,27 @@ def test_command_with_dangerous_chars():
 def test_command_with_path_and_arguments():
     assert contains_shell_syntax("/usr/bin/ls -l", "/usr/bin/ls") is True
     assert contains_shell_syntax("/bin/cp file1 file2", "/bin/cp") is True
+
+
+def test_newline_as_separator():
+    assert contains_shell_syntax("ls\nrm", "rm") is True
+    assert contains_shell_syntax("echo test\nrm -rf /", "rm") is True
+    assert contains_shell_syntax("rm\nls", "rm") is True
+
+
+def test_tab_as_separator():
+    assert contains_shell_syntax("ls\trm", "rm") is True
+    assert contains_shell_syntax("echo test\trm -rf /", "rm") is True
+    assert contains_shell_syntax("rm\tls", "rm") is True
+
+
+def test_carriage_return_as_separator():
+    assert contains_shell_syntax("ls\rrm", "rm") is True
+    assert contains_shell_syntax("echo test\rrm -rf /", "rm") is True
+    assert contains_shell_syntax("rm\rls", "rm") is True
+
+
+def test_form_feed_as_separator():
+    assert contains_shell_syntax("ls\frm", "rm") is True
+    assert contains_shell_syntax("echo test\frm -rf /", "rm") is True
+    assert contains_shell_syntax("rm\fls", "rm") is True

aikido_zen/vulnerabilities/shell_injection/detect_shell_injection_test.py

@@ -394,3 +394,35 @@ def test_it_flags_comma_in_loop():
     done""",
         "for (( i=0, j=10; i<j; i++, j-- ))",
     )
+
+
+def test_carriage_return_in_user_input_is_flagged():
+    is_shell_injection("ls \rrm", "\rrm")
+    is_shell_injection("ls \rrm -rf", "\rrm -rf")
+
+
+def test_form_feed_in_user_input_is_flagged():
+    is_shell_injection("ls \frm", "\frm")
+    is_shell_injection("ls \frm -rf", "\frm -rf")
+
+
+def test_carriage_return_in_user_input_is_flagged_when_userinput_is_command():
+    is_shell_injection("sleep\r10", "sleep\r10")
+    is_shell_injection("shutdown\r-h\rnow", "shutdown\r-h\rnow")
+
+
+def test_form_feed_in_user_input_is_flagged_when_userinput_is_command():
+    is_shell_injection("sleep\f10", "sleep\f10")
+    is_shell_injection("shutdown\f-h\fnow", "shutdown\f-h\fnow")
+
+
+def test_carriage_return_as_separator_between_commands():
+    is_shell_injection("ls\rrm", "rm")
+    is_shell_injection("echo test\rrm -rf /", "rm")
+    is_shell_injection("rm\rls", "rm")
+
+
+def test_form_feed_as_separator_between_commands():
+    is_shell_injection("ls\frm", "rm")
+    is_shell_injection("echo test\frm -rf /", "rm")
+    is_shell_injection("rm\fls", "rm")