Add setToken() for secret managers#1012
Draft
hansott wants to merge 2 commits into
Draft
Conversation
Users who store their token in a secrets manager (e.g. AWS Secrets Manager) can't set AIKIDO_TOKEN before the module loads. prepare() starts instrumentation without a token, and setToken() connects to the platform once the token is fetched async. Teams shouldn't have to modify their whole app structure just to adopt Zen.
hansott
force-pushed
the
add-prepare-and-set-token
branch
from
653c63b to
72adc28
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hansott
changed the title
hansott
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users who store their token in a secrets manager (e.g. AWS Secrets Manager) can't set AIKIDO_TOKEN before the module loads. prepare() starts instrumentation without a token, and setToken() connects to the platform once the token is fetched async. Teams shouldn't have to modify their whole app structure just to adopt Zen.