chore(frontend): Remove dead SessionDrawerButton copied from TraceDrawer#5457
Open
ardaerzin wants to merge 1 commit into
Open
chore(frontend): Remove dead SessionDrawerButton copied from TraceDrawer#5457ardaerzin wants to merge 1 commit into
ardaerzin wants to merge 1 commit into
Conversation
The component was never adapted to sessions: it still targeted the trace drawer atoms, resolved a trace_id from a playground result, and had no importers. The session drawer is opened via openSessionDrawerAtom from the URL state layer instead. Also removes SessionDrawer/types.ts, which held only the button's props interface.
dosubot
Bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
Bot
added
Frontend
refactoring
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Railway Preview Environment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SessionDrawer/components/SessionDrawerButtonwas copied from TraceDrawer'sTraceDrawerButtonbut never adapted to sessions. It still targeted the trace drawer (importingopenTraceDrawerAtom/setTraceDrawerActiveSpanAtom, names the session store never exported) and resolved atrace_idfrom a playground result, which has no session equivalent. Nothing imports it; the session drawer is opened throughopenSessionDrawerAtomfrom the URL state layer (state/url/session.ts).Changes
Deletes the component and
SessionDrawer/types.ts, which held only the button's props interface and had no other importers. 168 lines removed, no code added.Tests / notes
SessionDrawerButtonorSessionDrawer/types.tsc --noEmiton@agenta/oss: no errors related to this change. The two pre-existingTraceSpanNodemismatch errors insessionDrawerStore.tsare untouched (known ts-chore baseline).