-
Notifications
You must be signed in to change notification settings - Fork 540
fix: surface actual provider error messages in evaluation table #4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -69,7 +69,7 @@ export const upsertStepResultWithInvocation = async ({ | |||||
| status: string | ||||||
| references?: InvocationReferences | ||||||
| outputs?: unknown | ||||||
| error?: {message: string; stacktrace?: string} | ||||||
| error?: {message: string; stacktrace?: string; type?: string} | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include This boundary type currently blocks status-code propagation, so HTTP/provider code can be lost before UI rendering. Proposed fix- error?: {message: string; stacktrace?: string; type?: string}
+ error?: {message: string; code?: string; stacktrace?: string; type?: string}📝 Committable suggestion
Suggested change
|
||||||
| }): Promise<void> => { | ||||||
| const {projectId} = getProjectValues() | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forward
result.error.codewhen persisting invocation failures.The failure payload currently strips
code, so UI/error tooling cannot show provider/HTTP code consistently.Proposed fix
error: { message: errorMessage, + ...(result.error?.code ? {code: result.error.code} : {}), ...(result.error?.stacktrace ? {stacktrace: result.error.stacktrace} : {}), ...(result.error?.type ? {type: result.error.type} : {}), },📝 Committable suggestion