[4535] fix(frontend): fix evaluator playground navigation from trace drawer#4560
[4535] fix(frontend): fix evaluator playground navigation from trace drawer#4560axelray-dev wants to merge 2 commits into
Conversation
Signed-off-by: axelray-dev <110029405+axelray-dev@users.noreply.github.com>
…535] Replace programmatic router.push with native href on the evaluator button so that clicking always navigates even if the trace drawer close handler does not complete. Removes the unused navigateToEvaluator call and preventDefault, keeping only stopPropagation to avoid triggering the parent popover's hover behavior.
|
@axelray-dev is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Too much diff to scan? Review this PR in Change Stack to start with the highest-impact changes. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
Walkthrough
ChangesEvaluator Navigation Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #4535.
Summary
The trace drawer evaluator popover was using programmatic navigation (router.push) to open the evaluator playground, but closing the trace drawer first could prevent the navigation from completing. This switches the evaluator action button to a native link (href) so that clicking always navigates to the correct destination.
Testing
Verified locally
Added or updated tests
No new tests. This is a behavioral fix in the click handler (native link vs programmatic push). Existing component behavior is unchanged for the user-visible output.
QA follow-up
Demo
page@fa2d68cb812c018eab28fa6b3a11e959.webm
Checklist